Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to use a wider range of dates for AstroCalc/Ephemeris tool #3880

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Sep 4, 2024

Description

This patch adding ability to use a wider range of dates for AstroCalc/Ephemeris tool.

Fixes #3868 (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

github-actions bot commented Sep 4, 2024

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@gzotti
Copy link
Member

gzotti commented Sep 4, 2024

Thank you for going after this now. But as always a few observations:

When I open the panel, then change the simulation date in the usual time panel (or any other method), I see the AC panel has an option to set the "From" date to "now". Good! When the date is outside the range of Gregorian calendar, the year is displayed as 9999. In this case the system should auto-switch to W.R.D (Wide range dates? Why not just call the button JD?). The GUI has lots of space after "W.R.D." ("JD") for a label to display the date range in "common" dates.

You have to set two dates. The end date might also be configured with just 2 options "[+1] [second/minute/hour/day/month|year]" (i.e., a spinbox and a dropdown), this may be faster than fiddling with the calendar panel or counting the JD numbers. At least, I see I can copy/paste the start date to start configuring, then scrolling the mousewheel 20 clicks.

@alex-w alex-w marked this pull request as draft September 4, 2024 14:35
@alex-w
Copy link
Member Author

alex-w commented Sep 4, 2024

Well, let me try to create an another version of GUI…

@alex-w alex-w force-pushed the astrocalc/issue/3868 branch from e88dcb4 to f731738 Compare September 6, 2024 08:18
@alex-w alex-w marked this pull request as ready for review September 13, 2024 06:27
@alex-w alex-w added this to the 24.3 milestone Sep 13, 2024
@alex-w alex-w added the enhancement Improve existing functionality label Sep 13, 2024
@alex-w
Copy link
Member Author

alex-w commented Sep 13, 2024

@gzotti OK, what's about changes?

@Atque
Copy link
Contributor

Atque commented Sep 13, 2024

Is 100 months enough? What if someone wants to display the movement of Saturn throughout a Saturnian year?

@gzotti
Copy link
Member

gzotti commented Sep 13, 2024

Interface: Yes, I think everybody prefers this.
@Atque just say 30 years. And you can set custom intervals with really all regular options. (One may want to have "altitude at -8° solar altitude" over a year, but seriously this is awkward.)

@Atque
Copy link
Contributor

Atque commented Sep 13, 2024

just say 30 years. And you can set custom intervals with really all regular options. (One may want to have "altitude at -8° solar altitude" over a year, but seriously this is awkward.)

Ah, I'm stupid. I didn't realize we could change the unit.

"Object at given solar altitiude" is actually very useful when displaying visibility of e.g. Mercury. But that's for another PR.

@alex-w alex-w merged commit 6a3bd54 into master Sep 13, 2024
28 of 29 checks passed
@alex-w alex-w deleted the astrocalc/issue/3868 branch September 13, 2024 10:12
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Sep 16, 2024
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 22, 2024
Copy link

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality
Development

Successfully merging this pull request may close these issues.

AstroCalc/Ephemerides: Wider range of dates
3 participants