Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed URL autocorrection bug #107

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Fixed URL autocorrection bug #107

merged 1 commit into from
Sep 6, 2017

Conversation

Ostrenkiy
Copy link
Contributor

Задача: #APPS-1542

Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Исправили баг при автокоррекции URL

Описание:
Раньше исправляли все вхождения URL-а, начинающегося с / на URL с https://stepik.org. Это приводило к тому, что исправлялся URL не только в href= и прочих тегах, но и в тексте. Теперь исправляем только вхождения, начинающиеся с кавычки.

@Ostrenkiy Ostrenkiy added this to the 1.42 milestone Sep 5, 2017
@Ostrenkiy Ostrenkiy self-assigned this Sep 5, 2017
@Ostrenkiy Ostrenkiy requested a review from kvld September 5, 2017 23:05
@Ostrenkiy Ostrenkiy changed the title Fixed URL automatic stepik.org/ addition Fixed URL autocorrection bug Sep 5, 2017
Copy link
Contributor

@kvld kvld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Возможно, это не самое хорошее решение, но оно должно пофиксить замены в тех местах, где нам они не нужны.

@Ostrenkiy Ostrenkiy merged commit 25c6778 into dev Sep 6, 2017
@Ostrenkiy Ostrenkiy deleted the fix/url-autocorrection branch September 6, 2017 10:31
@Ostrenkiy Ostrenkiy mentioned this pull request Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants