Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificates change recipient name #1114

Merged
merged 6 commits into from
Feb 8, 2022
Merged

Certificates change recipient name #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77e2286
Fix emptySetPlaceholder visible while loading data APPS-3596
ivan-magda Feb 7, 2022
026e12e
Clean up legacy code
ivan-magda Feb 7, 2022
fb70e5d
Refactor rename
ivan-magda Feb 7, 2022
77eba4e
Add edit button
ivan-magda Feb 8, 2022
f4c88cf
Present prompt for change certificate name input alert
ivan-magda Feb 8, 2022
3f6a116
Save new full name
ivan-magda Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions Stepic.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@
080E1ACC212571D9006B58A9 /* StoryPartViewFactory.swift in Sources */ = {isa = PBXBuildFile; fileRef = 080E1ACB212571D9006B58A9 /* StoryPartViewFactory.swift */; };
080E1ACE212583E5006B58A9 /* StoryTemplatesAPI.swift in Sources */ = {isa = PBXBuildFile; fileRef = 080E1ACD212583E5006B58A9 /* StoryTemplatesAPI.swift */; };
080E80F51F0070C900DC0EA5 /* CodeLanguages.swift in Sources */ = {isa = PBXBuildFile; fileRef = 080E80F41F0070C900DC0EA5 /* CodeLanguages.swift */; };
080EBA331EA64BC000C43C93 /* PresentationContainer.swift in Sources */ = {isa = PBXBuildFile; fileRef = 080EBA321EA64BC000C43C93 /* PresentationContainer.swift */; };
080EBA371EA64C0C00C43C93 /* CertificatesPresentationContainer.swift in Sources */ = {isa = PBXBuildFile; fileRef = 080EBA361EA64C0C00C43C93 /* CertificatesPresentationContainer.swift */; };
080F211B2034DA2500A1204C /* LocalProgressLastViewedUpdater.swift in Sources */ = {isa = PBXBuildFile; fileRef = 080F211A2034DA2500A1204C /* LocalProgressLastViewedUpdater.swift */; };
080F31DD1BA7162C00F356A0 /* StepikToken.swift in Sources */ = {isa = PBXBuildFile; fileRef = 080F31DC1BA7162C00F356A0 /* StepikToken.swift */; };
081387E11D7AF7700092E05D /* StyledTabBarViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 081387E01D7AF7700092E05D /* StyledTabBarViewController.swift */; };
Expand Down Expand Up @@ -2009,8 +2007,6 @@
080E1ACB212571D9006B58A9 /* StoryPartViewFactory.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StoryPartViewFactory.swift; sourceTree = "<group>"; };
080E1ACD212583E5006B58A9 /* StoryTemplatesAPI.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StoryTemplatesAPI.swift; sourceTree = "<group>"; };
080E80F41F0070C900DC0EA5 /* CodeLanguages.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CodeLanguages.swift; sourceTree = "<group>"; };
080EBA321EA64BC000C43C93 /* PresentationContainer.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PresentationContainer.swift; sourceTree = "<group>"; };
080EBA361EA64C0C00C43C93 /* CertificatesPresentationContainer.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CertificatesPresentationContainer.swift; sourceTree = "<group>"; };
080F211A2034DA2500A1204C /* LocalProgressLastViewedUpdater.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LocalProgressLastViewedUpdater.swift; sourceTree = "<group>"; };
080F31DC1BA7162C00F356A0 /* StepikToken.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StepikToken.swift; sourceTree = "<group>"; };
081387E01D7AF7700092E05D /* StyledTabBarViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StyledTabBarViewController.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -7332,7 +7328,6 @@
children = (
2CFF8FF6242A1E9F00FD7311 /* Defaults */,
2CFF8FF7242A1EAA00FD7311 /* Preferences */,
2CFF8FF8242A1EB800FD7311 /* Presentation */,
);
path = Containers;
sourceTree = "<group>";
Expand All @@ -7356,15 +7351,6 @@
path = Preferences;
sourceTree = "<group>";
};
2CFF8FF8242A1EB800FD7311 /* Presentation */ = {
isa = PBXGroup;
children = (
080EBA361EA64C0C00C43C93 /* CertificatesPresentationContainer.swift */,
080EBA321EA64BC000C43C93 /* PresentationContainer.swift */,
);
path = Presentation;
sourceTree = "<group>";
};
2CFF8FF9242A228C00FD7311 /* TransitionRouters */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -11479,7 +11465,6 @@
2C22042720E277E50060117A /* SkeletonView.swift in Sources */,
08F555651C4FF22600C877E8 /* QuizControllerDelegate.swift in Sources */,
0891424B1BCEE4EF0000BCB0 /* VideoURL.swift in Sources */,
080EBA371EA64C0C00C43C93 /* CertificatesPresentationContainer.swift in Sources */,
089877A0214047650065DFA2 /* SplitTestGroupProtocol.swift in Sources */,
2CF08864205BEF3C00FCB9C0 /* StepikPlaceholderView.swift in Sources */,
2C6E9CDB1FF27543001821A2 /* AdaptiveStorageManager.swift in Sources */,
Expand Down Expand Up @@ -11587,7 +11572,6 @@
2C2F0BE92186EF87007DCA0A /* CommonNotificationsRequestAlertDataSource.swift in Sources */,
086BE2851F901CCF00B4BE56 /* LastStepRouter.swift in Sources */,
2CECFD5526861FAA00849590 /* CourseBenefitDetailOutputProtocol.swift in Sources */,
080EBA331EA64BC000C43C93 /* PresentationContainer.swift in Sources */,
084DDDE1204EDF7600913503 /* NotificationRequestAlertViewController.swift in Sources */,
2C2485472101D91F006F8858 /* RestorableBackgroundDownloaderProtocol.swift in Sources */,
2CE9BF46248D08A8004F6659 /* CodeSamplesPersistenceService.swift in Sources */,
Expand Down
35 changes: 27 additions & 8 deletions ...c/Legacy/Controllers/Certificates/CertificateTableViewCell/CertificateTableViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,30 @@
//
// CertificateTableViewCell.swift
// Stepic
//
// Created by Ostrenkiy on 12.04.17.
// Copyright © 2017 Alex Karpov. All rights reserved.
//

import UIKit

final class CertificateTableViewCell: UITableViewCell {
enum Appearance {
static let editButtonTopOffset: CGFloat = 8

static let actionButtonHeight: CGFloat = 31
}

@IBOutlet weak var courseTitle: StepikLabel!
@IBOutlet weak var certificateDescription: StepikLabel!
@IBOutlet weak var certificateResult: StepikLabel!
@IBOutlet weak var shareButton: UIButton!
@IBOutlet weak var courseImage: UIImageView!
@IBOutlet var editButton: UIButton!
@IBOutlet var editButtonTopConstraint: NSLayoutConstraint!
@IBOutlet var editButtonHeightConstraint: NSLayoutConstraint!

private var viewData: CertificateViewData?

var shareBlock: ((CertificateViewData, UIButton) -> Void)?
var editBlock: ((CertificateViewData, UIButton) -> Void)?

override func awakeFromNib() {
super.awakeFromNib()
self.shareButton.setTitle(NSLocalizedString("Share", comment: ""), for: .normal)
self.editButton.setTitle(NSLocalizedString("CertificateNameChangeAction", comment: ""), for: .normal)
}

func initWith(certificateViewData: CertificateViewData) {
Expand All @@ -33,6 +36,12 @@ final class CertificateTableViewCell: UITableViewCell {
url: certificateViewData.courseImageURL,
placeholder: Images.lessonPlaceholderImage.size50x50
)

self.editButton.isHidden = !certificateViewData.isEditAvailable
self.editButtonTopConstraint.constant = self.editButton.isHidden ? 0 : Appearance.editButtonTopOffset
self.editButtonHeightConstraint.constant = self.editButton.isHidden
? 0
: Appearance.actionButtonHeight
}

@IBAction
Expand All @@ -41,4 +50,14 @@ final class CertificateTableViewCell: UITableViewCell {
self.shareBlock?(viewData, sender)
}
}

@IBAction
func editPressed(_ sender: UIButton) {
guard let viewData = self.viewData,
viewData.isEditAvailable else {
return
}

self.editBlock?(viewData, sender)
}
}
Loading