Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix analytics events #142

Merged
merged 3 commits into from
Oct 31, 2017
Merged

Fix analytics events #142

merged 3 commits into from
Oct 31, 2017

Conversation

kvld
Copy link
Contributor

@kvld kvld commented Oct 24, 2017 •
edited
Loading

Задача: #APPS-1077, #APPS-1076, #APPS-1560, #APPS-1561

Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Пофиксили неотправляющиеся событий в аналитику и добавили события на интро видео в курсе

Описание:

  • Переименованы события на экране авторизации и регистрации
  • События в CourseOverview, связанные с интро видео
  • Фикс события при тапе на уведомлении о стрике

@kvld kvld changed the title Fix/analytics events Fix analytics events Oct 24, 2017
@kvld kvld requested a review from Ostrenkiy October 24, 2017 13:15
@kvld kvld self-assigned this Oct 24, 2017
@kvld kvld added this to the 1.46 milestone Oct 24, 2017
Ostrenkiy
Ostrenkiy approved these changes Oct 30, 2017
View reviewed changes
Copy link
Contributor

@Ostrenkiy Ostrenkiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По коду претензий нет, присылаются ли события - не смотрел :)

@kvld kvld merged commit 9659782 into dev Oct 31, 2017
@kvld kvld deleted the fix/analytics-events branch October 31, 2017 12:02
@Ostrenkiy Ostrenkiy mentioned this pull request Nov 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ostrenkiy Ostrenkiy Ostrenkiy approved these changes

Assignees

@kvld kvld

Labels
main
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
2 participants
@kvld @Ostrenkiy