Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PagerController refactoring #151

Merged
merged 1 commit into from
Oct 31, 2017
Merged

PagerController refactoring #151

merged 1 commit into from
Oct 31, 2017

Conversation

kvld
Copy link
Contributor

@kvld kvld commented Oct 27, 2017

Задача: #APPS-1590

Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Пофиксили краши в PagerController

Описание:
Вылечен PagerController от force unwrapping'ов, должно перестать крашиться в setActiveContentIndex() и других местах.

@kvld kvld added this to the 1.46 milestone Oct 27, 2017
@kvld kvld self-assigned this Oct 27, 2017
@kvld kvld requested a review from Ostrenkiy October 27, 2017 13:28
Copy link
Contributor

@Ostrenkiy Ostrenkiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Думаю, так вылечим еще пару процентов крашащихся пользователей.
Но, по-хорошему, это все полностью переписать конечно надо бы.

@kvld kvld merged commit 6669092 into dev Oct 31, 2017
@kvld kvld deleted the fix/pager-crashes branch October 31, 2017 12:02
@Ostrenkiy Ostrenkiy mentioned this pull request Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants