Skip to content

Auth refactoring & minor redesign #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 15, 2017
Merged

Auth refactoring & minor redesign #171

merged 8 commits into from
Nov 15, 2017

Conversation

kvld
Copy link
Contributor

@kvld kvld commented Nov 10, 2017

Задача: #APPS-1618

Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Рефакторинг авторизации и приведение её к актуальным макетам

Описание:

  • Код презентеров авторизации и регистрации, а также смежных классов, переписан с использованием PromiseKit
  • Мелкие изменения во view
    • Вёрстка кнопки "закрыть"
    • Отключен лендскейп на устройствах с диагональю < 5.5
    • safe area для iPhone X
  • Восстановлена отправка события success_login при авторизации через SDK соцсетей

TODO

  • Оттестировать на всех устройствах и ориентация

@kvld kvld added the main label Nov 10, 2017
@kvld kvld added this to the 1.47 milestone Nov 10, 2017
@kvld kvld self-assigned this Nov 10, 2017
@kvld kvld requested a review from Ostrenkiy November 10, 2017 14:30
@kvld kvld mentioned this pull request Nov 15, 2017
Merged
4 tasks
Ostrenkiy
Ostrenkiy reviewed Nov 15, 2017
View reviewed changes
Stepic/AuthAPI.swift
// Welcome to the legacy world!
// TODO: remove this extension after global refactoring
extension AuthAPI {
@available(*, deprecated, message: "Legacy method with callbacks")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай в message будем писать, какой метод стоит использовать вместо этого?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, можно.

Ostrenkiy
Ostrenkiy approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@Ostrenkiy Ostrenkiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не проверял, как хорошо это работает, однако понятно, что подмердживать в остальные PR-ы это надо будет осторожно. В Explore и Виджетах точно используются отрефакторенные здесь методы.

@kvld kvld merged commit 09a5903 into dev Nov 15, 2017
@kvld kvld deleted the refactor/auth branch November 15, 2017 23:08
@Ostrenkiy Ostrenkiy mentioned this pull request Nov 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Ostrenkiy Ostrenkiy Ostrenkiy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kvld kvld

Labels
main
Projects
None yet
Milestone
1.47
Development

Successfully merging this pull request may close these issues.
2 participants
@kvld @Ostrenkiy