Notifications minor fixes & PromiseKit refactoring #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ostrenkiy тут всё, можно смотреть. |
Ostrenkiy
suggested changes
Nov 16, 2017
Stepic/NotificationsAPI.swift
Outdated
| @@ -11,127 +11,91 @@ import Foundation | |||
| import Foundation | |||
| import Alamofire | |||
| import SwiftyJSON | |||
| import PromiseKit | |||
|
|
|||
| class NotificationsAPI { | |||
There was a problem hiding this comment.
А давай может APIEndpoint используем таки? Не очень понимаю, в чем проблема
There was a problem hiding this comment.
А в APIEndpoint разве есть пагинация и возможность передать параметры в getObjectsByIds()? Или ты предлагаешь это добавить туда?
| print("notifications: unable to update notification with id = \(id), error = \(err)") | ||
| }) | ||
| }) | ||
| checkToken().then { _ -> Promise<Notification> in |
There was a problem hiding this comment.
С checkToken() действительно не так уродливо все выглядит
| }, error: { err in | ||
| print("notifications: unable to mark all notifications as read, error = \(err)") | ||
| }.catch { error in | ||
| print("notifications: unable to mark all notifications as read, error = \(error)") |
There was a problem hiding this comment.
Думаю, стоит запилить логгер ошибок, который будет выводить их на экран и посылать события в аналитику
Ostrenkiy
approved these changes
Nov 17, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Фикс мелких багов в нотификациях и рефакторинг с PromiseKit
Описание:
TODO