Deep Links for catalog and notifications #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvld
approved these changes
Feb 21, 2018
|
|
||
| if components[1].lowercased() == "course" && components.count >= 3 { | ||
| if components.count == 2 && components[1].lowercased() == "catalog" { |
There was a problem hiding this comment.
С components.count == 2 будет отброшена, например, ссылка https://stepik.org/catalog/trending. Судя по задаче, так и задумывалось?
There was a problem hiding this comment.
Да, так и задумывается
Stepic/DeepLinkRouter.swift
Outdated
| guard let tabController = currentTabBarController else { | ||
| return | ||
| } | ||
| delay(0.05) { |
There was a problem hiding this comment.
Здесь можно делать delay(0). А ещё лучше комментировать такие места, чтобы в будущем понимать, зачем эта обёртка нужна была.
There was a problem hiding this comment.
+, сейчас переделаю
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1765
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Обновление deeplink для catalog и notifications.
Описание:
Обновили диплинки для catalog и notifications. Паша обновит
apple-app-site-association1 марта, когда релиз будет у большинства пользователей. Безdelayне работает, так как контроллеры во времяdidFinishLaunchingеще не проинициализированы.