Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New adaptive targets #243

Merged
merged 14 commits into from
Mar 12, 2018
Merged

New adaptive targets #243

merged 14 commits into from
Mar 12, 2018

Conversation

kvld
Copy link
Contributor

@kvld kvld commented Feb 27, 2018

Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Обновление конфигов для адаптивных таргетов

Описание:
Обновлены конфиги всех адаптивных таргетов. Для таргета с ПДД обновлена иконка. Таргет с 3067 курсом переделан в общий для GMAT.
Попутно исправлены:

  • проблема с версткой шкалы прогресса при повороте
  • проблема с обновлением плейсхолдера
  • добавлена обработка ситуации с ошибкой рефреша токена
  • для контрола с аудио цвет берется из параметра stepicGreen, а он в свою очередь вынесен в конфиг

TODO

  • Firebase для GMAT
  • fastlane

Sorry, something went wrong.

@kvld kvld self-assigned this Feb 27, 2018
@kvld kvld requested a review from Ostrenkiy February 27, 2018 21:03
@kvld kvld added this to the 1.54 milestone Mar 1, 2018
@@ -252,6 +261,10 @@ class BaseCardsStepsPresenter: CardsStepsPresenter, StepCardViewDelegate {
view?.refreshCards()
}

func logout() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нам нужен этот пустой метод?

@@ -36,7 +36,7 @@ class AdaptiveCourseSelectPresenter {

var defaultsStorageManager: DefaultsStorageManager

var initialActions: Promise<([Course], [AdaptiveCourseInfo])>?
var initialActions: ((((([Course], [AdaptiveCourseInfo])) -> Void)?, ((Error) -> Void)?) -> Void)?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а почему тут промисы выпилили?

@kvld kvld merged commit f4b6f61 into dev Mar 12, 2018
@kvld kvld deleted the fix/adaptive-configs branch March 12, 2018 09:42
@kvld kvld mentioned this pull request Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants