Notifications request after action #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kvld надо смотреть |
|
@Ostrenkiy а оставшиеся пункты в TODO? |
kvld
suggested changes
Mar 12, 2018
| @@ -114,7 +118,7 @@ class BaseCardsStepsPresenter: CardsStepsPresenter, StepCardViewDelegate { | |||
| return true | |||
| } | |||
|
|
|||
| init(stepsAPI: StepsAPI, lessonsAPI: LessonsAPI, recommendationsAPI: RecommendationsAPI, unitsAPI: UnitsAPI, viewsAPI: ViewsAPI, ratingsAPI: AdaptiveRatingsAPI, ratingManager: AdaptiveRatingManager, statsManager: AdaptiveStatsManager, storageManager: AdaptiveStorageManager, lastViewedUpdater: LocalProgressLastViewedUpdater, course: Course?, view: CardsStepsView) { | |||
| init(stepsAPI: StepsAPI, lessonsAPI: LessonsAPI, recommendationsAPI: RecommendationsAPI, unitsAPI: UnitsAPI, viewsAPI: ViewsAPI, ratingsAPI: AdaptiveRatingsAPI, ratingManager: AdaptiveRatingManager, statsManager: AdaptiveStatsManager, storageManager: AdaptiveStorageManager, lastViewedUpdater: LocalProgressLastViewedUpdater, notificationSuggestionManager: NotificationSuggestionManager, notificationPermissionManager: NotificationPermissionManager, course: Course?, view: CardsStepsView) { | |||
There was a problem hiding this comment.
Это не ломает ничего в адаптивных таргетах?
There was a problem hiding this comment.
Скорее всего ломает, сейчас посмотрю
| case .authorized: | ||
| self?.selectStreakNotificationTime() | ||
| case .denied: | ||
| //TODO: Add dialog to tell user he should have permitteed the notifications |
| @@ -18,25 +18,40 @@ class StreaksStepikAlertManager: AlertManager, StreaksAlertPresentationDelegate | |||
| // controller.present(alert, animated: true, completion: nil) | |||
| } | |||
|
|
|||
| //TODO: Add DI here | |||
kvld
suggested changes
Mar 12, 2018
| @@ -132,6 +133,10 @@ class CardsStepsViewController: UIViewController, CardsStepsView { | |||
| state = .congratulation | |||
| Alerts.congratulation.present(alert: controller, inController: ControllerHelper.getTopViewController() ?? self) | |||
| } | |||
|
|
|||
| func present(alertManager: AlertManager, alert: UIViewController) { | |||
There was a problem hiding this comment.
На самом деле, метод showCongratulationPopup выше делает почти то же самое. И кажется, что он теперь не нужен. Надо или переделать сразу или как-то пометить, наверное, чтобы выпилить не в рамках этого пулл-реквеста.
There was a problem hiding this comment.
Пока не будем выпиливать
| lastStreakAlertShownTime = Date().timeIntervalSince1970 | ||
| private func setLastAlertShownTime(time: TimeInterval, for context: NotificationRequestAlertContext) { | ||
| defaults.set(time, forKey: lastTimeKey(for: context)) | ||
| defaults.synchronize() |
There was a problem hiding this comment.
На самом деле
synchronize()
Waits for any pending asynchronous updates to the defaults database and returns; this method is unnecessary and shouldn't be used.
Stepic/en.lproj/Localizable.strings
Outdated
| @@ -401,5 +401,12 @@ LessonDownloadTooltip = "Download lesson "; | |||
| ContinueLearningWidgetTooltip = "Tap to continue from where you finished last time"; | |||
| StreaksSwitchTooltip = "Turn on to get new portion of knowledge every day"; | |||
|
|
|||
| /* Notification alerts */ | |||
| NotificationTabNotificationRequestAlertTitle = "Stay tuned"; | |||
| NotificationTabNotificationRequestAlertMessage = "We are trying to make learning process effective and comfortable. Enable notifications to follow discussions and promptly recieve courses updates?"; | |||
Stepic/en.lproj/Localizable.strings
Outdated
| NotificationTabNotificationRequestAlertMessage = "We are trying to make learning process effective and comfortable. Enable notifications to follow discussions and promptly recieve courses updates?"; | ||
|
|
||
| CourseSubscriptionNotificationRequestAlertTitle = "Stay tuned"; | ||
| CourseSubscriptionNotificationRequestAlertMessage = "We are trying to make learning process effective and comfortable. Enable notifications to follow deadlines and promptly recieve course updates?"; |
kvld
approved these changes
Mar 12, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1792 #APPS-1732
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Запрашиваем разрешение на уведомления красиво и в тот момент, когда пользователь хочет ответить "да"
Описание:
С помощью
NotificationPermissionManagerтеперь контролируем то, как пользователь записывается на уведомления. В алерте показываем анимацию с колокольчиком с помощью Lottie. С помощьюNotificationSuggestionManagerмы контролируем частоту и интервалы показа уведомлений.StreakAlertViewControllerпревратили вNotificationRequestAlertViewController, который переиспользуем для отображения алертов про разрешение нотификаций.TODO
StreakAlertViewController->NotificationRequestAlertViewController, в котором можно выбирать отображаемый текст в зависимости от контекста.