-
Notifications
You must be signed in to change notification settings - Fork 35
New placeholders #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New placeholders #250
Conversation
По тому, как использовать - сделано очень круто и удобно, прям 10/10. |
Stepic/StepikPlaceholderView.swift
Outdated
|
||
lazy private var allPlaceholders: [StepikPlaceholderStyle.PlaceholderId: StepikPlaceholderStyle] = { | ||
var idToView: [StepikPlaceholderStyle.PlaceholderId: StepikPlaceholderStyle] = [:] | ||
for (k, v) in zip(StepikPlaceholder.availablePlaceholders.map({ $0.id }), StepikPlaceholder.availablePlaceholders) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
это ведь можно заменить на
for placeholder in StepikPlaceholder.availablePlaceholders {
idToView[placeholder.id] = placeholder
}
Stepic/StepikPlaceholderView.swift
Outdated
static let vertical = CGFloat(500) | ||
} | ||
|
||
struct imageHeightToFrameHeightRation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
опечатка: Ratio
self.tableView.emptyDataSetSource = self | ||
|
||
tableView.emptySetPlaceholder = StepikPlaceholder(.emptyDownloads) { [weak self] in | ||
self?.tabBarController?.selectedIndex = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
надо будет порефакторить tabBarController, чтобы селектить по айдишке, а не по индексу
но сейчас норм и так
Задача: #APPS-1808
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Обновили плейсхолдеры
Описание:
Обновленные (по макетам) плейсхолдеры. Добавлен класс
StepikTableView
– UITableView, для которого поддерживаются пустые состояния. Все базовые плейсхолдеры объявлены как static-константы вStepikPlaceholder.Style
. Пример использования:TODO
Замена