Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New autocomplete keywords #258

Merged
merged 3 commits into from
Apr 2, 2018
Merged

New autocomplete keywords #258

merged 3 commits into from
Apr 2, 2018

Conversation

kvld
Copy link
Contributor

@kvld kvld commented Mar 26, 2018

Задача: #APPS-1827

Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Добавили в автокомплит слова для Kotlin, R и Haskell

Описание:
Добавлены слова для новых языков и вместе с этим все слова перенесены в отдельный plist.

@kvld kvld self-assigned this Mar 26, 2018
@kvld kvld requested a review from Ostrenkiy March 26, 2018 11:25
@kvld kvld added this to the 1.56 milestone Mar 26, 2018
"Comparable",
"Enumerable"
]
private static func loadSuggestionsFromFile(language: String) -> [String] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Думаю, нам стоит создать отдельный сервис для загрузки plist-ов, потому что примерно один и тот же код все время дублируется (но это в отдельном PR-е когда-нибудь)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018-04-01 14 28 34

@kvld kvld merged commit cf88a20 into dev Apr 2, 2018
@kvld kvld deleted the feature/new-code-quiz-keywords branch April 2, 2018 18:09
@kvld kvld mentioned this pull request Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants