Video in background #261
Merged
Video in background #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ostrenkiy
suggested changes
Apr 2, 2018
| show(direction: direction, in: inView, from: fromView, isArrowVisible: true) | ||
| } | ||
|
|
||
| func show(direction: TooltipDirection, in inView: UIView?, from fromView: UIView, isArrowVisible: Bool) { |
There was a problem hiding this comment.
можно просто сделать isArrowVisible: Bool = true дефолтным параметром в методе. Тогда тот, что выше, будет не нужен
There was a problem hiding this comment.
Он под протоколом, а протоколы не разрешают дефолтное значение для аргументов. А если мы уберём метод, который без isArrowVisible и оставим в протоколе 2 метода (для UIView с isArrowVisible и для UIBarButtonItem), то не сможем вызывать метод для UIView.
Ostrenkiy
approved these changes
Apr 2, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1825
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Добавили возможность воспроизводить видео при свернутом приложении
Описание:
В RemoteConfig добавлен параметр, который включает возможность воспроизводить видео при свернутом приложении. Воспроизведение без пауз при сворачивании – Technical Q&A QA1668