Fix user-agent #279
Merged
Fix user-agent #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ostrenkiy
suggested changes
Apr 17, 2018
Stepic/RequestChain.swift
Outdated
| @@ -25,7 +25,7 @@ class RequestChain { | |||
|
|
|||
| func start(_ completionHandler: @escaping CompletionHandler) { | |||
| if let request = requests.first { | |||
| Alamofire.request(request as! URLRequestConvertible).response { | |||
| AlamofireDefaultSessionManager.shared.request(request as! URLRequestConvertible).response { | |||
There was a problem hiding this comment.
Кажется, RequestChain нигде не используется и это можно выпилить вообще
Stepic/QueriesAPI.swift
Outdated
| @@ -19,7 +19,7 @@ class QueriesAPI: APIEndpoint { | |||
|
|
|||
| let params: Parameters = ["query": query] | |||
|
|
|||
| return Alamofire.request("\(StepicApplicationsInfo.apiURL)/\(name)", parameters: params, headers: headers).responseSwiftyJSON({ | |||
| return AlamofireDefaultSessionManager.shared.request("\(StepicApplicationsInfo.apiURL)/\(name)", parameters: params, headers: headers).responseSwiftyJSON({ | |||
There was a problem hiding this comment.
Здесь надо заменить на просто manager
Stepic/EnrollmentsAPI.swift
Outdated
| @@ -39,7 +39,7 @@ class EnrollmentsAPI: APIEndpoint { | |||
| ] | |||
|
|
|||
| if !delete { | |||
| return Alamofire.request("\(StepicApplicationsInfo.apiURL)/\(name)", method: .post, parameters: params, encoding: JSONEncoding.default, headers: headers).responseSwiftyJSON({ | |||
| return AlamofireDefaultSessionManager.shared.request("\(StepicApplicationsInfo.apiURL)/\(name)", method: .post, parameters: params, encoding: JSONEncoding.default, headers: headers).responseSwiftyJSON({ | |||
There was a problem hiding this comment.
можно заменить на manager. здесь и везде, где наследуется от ApiEndpoint
| import Foundation | ||
|
|
||
| class StepikURLSessionConfiguration: URLSessionConfiguration { | ||
| private static func buildUserAgent() -> String { |
There was a problem hiding this comment.
думаю, будет лучше, если заменить на var
(но это по желанию - как самому больше нравится)
|
@Ostrenkiy смотри. |
Ostrenkiy
approved these changes
Apr 18, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1862
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Зафиксировали юзер-агент для всех сетевых запросов
Описание:
Описание формата юзер-агента в задаче в ютреке. Добавлен класс
AlamofireDefaultSessionManager, для которого задается юзер-агент и который следует использовать вместо вызова глобальных функций из Alamofire.