Hide language widget after first session #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvld
suggested changes
Jun 7, 2018
|
|
||
| @IBOutlet weak var languageLabel: StepikLabel! | ||
|
|
||
| override func awakeFromNib() { |
| @@ -15,4 +15,5 @@ class DefaultsContainer { | |||
| private init() {} | |||
| static let launch = LaunchDefaultsContainer() | |||
| static let personalDeadlines = PersonalDeadlinesDefaultsContainer() | |||
| static let explore = ExploreDefaultsContainer() | |||
There was a problem hiding this comment.
Нужно будет подумать, как сделать аккуратно. Потому что плодим какие-то ненужные сущности, внутри которых один и тот же код с точностью до констант с ключами.
Stepic/SettingsPresenter.swift
Outdated
|
|
||
| private func buildTitleMenuBlock(id: String, title: String) -> HeaderMenuBlock { | ||
| return HeaderMenuBlock(id: id, title: title) | ||
| enum BlockID: String { |
There was a problem hiding this comment.
Предлагаю сделать как в Profile --- делать инициализацию блоков во вью слое, а если надо иметь какую-то логику, то иметь ее в презентере.
| @@ -16,6 +16,7 @@ class DefaultsStorageManager { | |||
| private let accountEmailKey = "account_email" | |||
| private let accountPasswordKey = "account_password" | |||
| private let lastCourseIdKey = "last_course_id" | |||
|
|
|||
There was a problem hiding this comment.
ну, добавился отступ лишний, бывает)
kvld
previously requested changes
Jun 12, 2018
Stepic/SettingsMenuBlock.swift
Outdated
|
|
||
| import Foundation | ||
|
|
||
| enum SettingsMenuBlock: String, Equatable { |
There was a problem hiding this comment.
Тут, кстати, нет хранимых значений в case, вроде можно не определять Equatable и писать просто
enum SettingsMenuBlock: String { ... }
Stepic/SettingsPresenter.swift
Outdated
| func changeVideoQuality(action: VideoQualityChoiceAction) | ||
| func changeCodeEditorSettings() | ||
| func changeContentLanguageSettings() | ||
| func setMenu(menuIDs: [SettingsMenuBlock]) |
There was a problem hiding this comment.
Лучше делать IDs сейчас и дальше, так логичнее
kvld
approved these changes
Jun 14, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1897
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Выпилили language widget из explore при первом просмотре
Описание:
Просто добавил нужный UI и нужное поведение. Еще немного порефакторил блоки в
SettingsPresenterи еще в нескольких местах по мелочи.