Show topic lessons #332
Merged
Show topic lessons #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvld
approved these changes
Jul 30, 2018
| import PromiseKit | ||
|
|
||
| final class EnrollmentServiceImpl: EnrollmentService { | ||
| private enum EnrollmentServiceError: Error { |
There was a problem hiding this comment.
Из-за приватности нельзя будет проверить, что ошибка принадлежит к EnrollmentServiceError.
| self.enrollmentsAPI.joinCourse(course).done { | ||
| seal.fulfill(course) | ||
| }.catch { _ in | ||
| seal.reject(EnrollmentServiceError.joinCourseFailed) |
There was a problem hiding this comment.
Если мы где-то явно не проверяем, что за ошибка произошла при записи на курс, имеет смысл записать тело как return self.enrollmentsAPI.joinCourse(course)
| // MARK: - Private API | ||
|
|
||
| private func joinCoursesIfNeeded() { | ||
| guard !coursesIds.isEmpty else { return } |
There was a problem hiding this comment.
Чтобы guard не сливался с остальным кодом, предлагаю форматировать его как всё остальное (не в одну строку) и отделять пустой строкой после.
Ostrenkiy
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1974
Описание:
Разбил основную задачу на 2 части. Добавил возможность просматривать список уроков для каждого топика.
В следующем PR будут степы (просмотр теории).