Show no submissions message when there is no attempts left #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvld
suggested changes
Aug 10, 2018
Stepic/QuizPresenter.swift
Outdated
| @@ -333,21 +335,25 @@ class QuizPresenter { | |||
| [weak self] | |||
| submission in | |||
|
|
|||
| guard let s = self else { return } | |||
| guard let `self` = self else { | |||
There was a problem hiding this comment.
Предлагаю использовать strongSelf для такого обозначения. Так можно сразу понимать, о чем речь.
There was a problem hiding this comment.
Хорошо. Я по-моему изначально подумал, что s это submission или любой другой объекто, но точно не self 
kvld
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1888
Описание:
Отображение сообщения о том что попытки закончились в шаге с ограниченными попытками.