-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support localization #350
Support localization #350
Conversation
Stepic/en.lproj/Localizable.strings
Outdated
|
||
/* ExamEGERussian */ | ||
"ErrorMessage" = "Sorry, something went wrong: please try again later."; | ||
"Ок" = "Ок"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Кириллица
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Точно, как ты заметил 👍
Может Ok
вообще не нужно добавлять ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему не нужно?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В основном приложении не было изначально, да и обычно не переводят так и оставляют. Ну или Ok -> Хорошо
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Если такая фраза есть в интерфейсе, значит тут она тоже должна быть. Просто можно (и желательно) называть ключи в контексте интерфейса, а не в контексте смысла фраз.
@@ -0,0 +1,9 @@ | |||
|
|||
/* Class = "UIButton"; normalTitle = "Later"; ObjectID = "Y0m-Dy-BFE"; */ | |||
"Y0m-Dy-BFE.normalTitle" = "Later"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Локализации сторибордов не должно быть, если планируется изменять эти экраны.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Задача: #APPS-2010
Описание:
Поддержали русскую и английскую локализацию.
P.S. пробежался по исходникам и проверил на наличие строк, обернул в NSLocalizedString, проверил в русском/английском языках системы.