Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support localization #350

Merged
merged 5 commits into from
Aug 24, 2018
Merged

Support localization #350

merged 5 commits into from
Aug 24, 2018

Conversation

ivan-magda
Copy link
Member

Задача: #APPS-2010

Описание:
Поддержали русскую и английскую локализацию.

P.S. пробежался по исходникам и проверил на наличие строк, обернул в NSLocalizedString, проверил в русском/английском языках системы.

@ivan-magda ivan-magda self-assigned this Aug 24, 2018
@ivan-magda ivan-magda requested a review from kvld August 24, 2018 12:41
@ivan-magda ivan-magda changed the title Feature/exam localization Support localization Aug 24, 2018

/* ExamEGERussian */
"ErrorMessage" = "Sorry, something went wrong: please try again later.";
"Ок" = "Ок";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кириллица

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точно, как ты заметил 👍
Может Ok вообще не нужно добавлять ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему не нужно?

Copy link
Member Author

@ivan-magda ivan-magda Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В основном приложении не было изначально, да и обычно не переводят так и оставляют. Ну или Ok -> Хорошо

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если такая фраза есть в интерфейсе, значит тут она тоже должна быть. Просто можно (и желательно) называть ключи в контексте интерфейса, а не в контексте смысла фраз.

@@ -0,0 +1,9 @@

/* Class = "UIButton"; normalTitle = "Later"; ObjectID = "Y0m-Dy-BFE"; */
"Y0m-Dy-BFE.normalTitle" = "Later";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Локализации сторибордов не должно быть, если планируется изменять эти экраны.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@ivan-magda ivan-magda merged commit 4238e2e into dev Aug 24, 2018
@ivan-magda ivan-magda deleted the feature/exam-localization branch August 24, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants