AB infrastructure #357
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // | ||
| // AnalyticsUserPropertiesServiceProtocol.swift | ||
| // SplitTests | ||
| // | ||
| // Created by Alex Zimin on 15/06/2018. | ||
| // Copyright © 2018 Akexander. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| protocol AnalyticsUserPropertiesServiceProtocol { | ||
| func setProperty(key: String, value: Any?) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // | ||
| // Numbers.swift | ||
| // SplitTests | ||
| // | ||
| // Created by Alex Zimin on 15/06/2018. | ||
| // Copyright © 2018 Akexander. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
| import CoreGraphics | ||
|
|
||
| public extension Int { | ||
| /// SwiftRandom extension | ||
| public static func random(lower: Int = 0, _ upper: Int = 100) -> Int { | ||
| return lower + Int(arc4random_uniform(UInt32(upper - lower + 1))) | ||
| } | ||
| } | ||
|
|
||
| public extension Float { | ||
|
|
||
| /// Returns a random floating point number between 0.0 and 1.0, inclusive. | ||
| public static var random: Float { | ||
| return Float(arc4random()) / 0xFFFFFFFF | ||
| } | ||
|
|
||
| /// Random float between 0 and n-1. | ||
| /// | ||
| /// - Parameter n: Interval max | ||
| /// - Returns: Returns a random float point number between 0 and n max | ||
| public static func random(min: Float, max: Float) -> Float { | ||
| return Float.random * (max - min) + min | ||
| } | ||
| } | ||
|
|
||
| public extension CGFloat { | ||
|
|
||
| /// Randomly returns either 1.0 or -1.0. | ||
| public static var randomSign: CGFloat { | ||
| return (arc4random_uniform(2) == 0) ? 1.0 : -1.0 | ||
| } | ||
|
|
||
| /// Returns a random floating point number between 0.0 and 1.0, inclusive. | ||
| public static var random: CGFloat { | ||
| return CGFloat(Float.random) | ||
| } | ||
|
|
||
| /// Random CGFloat between 0 and n-1. | ||
| /// | ||
| /// - Parameter n: Interval max | ||
| /// - Returns: Returns a random CGFloat point number between 0 and n max | ||
| public static func random(min: CGFloat, max: CGFloat) -> CGFloat { | ||
| return CGFloat.random * (max - min) + min | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
У нас по-прежнему есть несколько провайдеров аналитики, поэтому подгонять под протокол меняя названия и модификатор доступа – не самая лучшая идея. Есть предложение сделать протокол не про задание проперти, а про задание проперти, связанной с A/B тестом. Тогда не нужно будет подгонять под протокол методы, а просто сделать отдельный метод, как я предлагал в предыдущем ревью.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не понимаю, чем плохо.
У нас есть протокол про проперти.
Я подогнал класс с проперти под этот протокол, просто переименовав один метод, который до этого был вообще приватным.
Другие провайдеры пока это не реализуют, но мы это и не используем.
В чем проблема здесь, я не вижу
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В чем смысл делать отдельный протокол про задание проперти для ab, если это будет то же самое, что и просто задание проперти?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно сказать про SOLID и ISP в нем, но к этому это вообще вряд ли относится, потому что разделить предлагается не по смыслу (не вижу кейсов, в котором задание юзер проперти и юзер проперти в ab-тесте будет различаться хоть как-то).