Deeplink router #363
Merged
Deeplink router #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvld
suggested changes
Sep 19, 2018
Stepic/AppDelegate.swift
Outdated
| } | ||
| }) | ||
| let deepLinkRoutingService = DeepLinkRoutingService() | ||
| delay(0.1) { |
There was a problem hiding this comment.
Оно не работает без delay? Или это хак с DispatchQueue.main.async? В таком случае, нужно ли нам 0.1?
Stepic/DeepLinkRoutingService.swift
Outdated
|
|
||
| func route(path: String, from source: UIViewController? = nil) { | ||
| let route = Route(path: path) | ||
| getModuleStack(route: route).done { moduleStack in |
There was a problem hiding this comment.
Еще мы договаривались писать self явно везде. Считаю, что пора начинать и привыкать
|
мержу? |
ivan-magda
approved these changes
Sep 19, 2018
kvld
approved these changes
Sep 20, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-2012
Описание:
Новый сервис для диплинк роутинга.
Для инициализации старых модулей, где сложно добавить синхронные assembly, был использован старый
DeepLinkRouter.