Notifications service #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create LocalNotificationService for managing, scheduling and getting local notifications.
|
@Ostrenkiy, добавил аналитику открытия нотификаций. Используется в NotificationsService:
|
kvld
reviewed
Oct 16, 2018
kvld
reviewed
Oct 16, 2018
kvld
reviewed
Oct 16, 2018
kvld
reviewed
Oct 16, 2018
kvld
reviewed
Oct 16, 2018
kvld
reviewed
Oct 16, 2018
kvld
reviewed
Oct 16, 2018
kvld
reviewed
Oct 16, 2018
kvld
reviewed
Oct 16, 2018
kvld
reviewed
Oct 16, 2018
kvld
reviewed
Oct 16, 2018
Ostrenkiy
reviewed
Oct 16, 2018
kvld
suggested changes
Oct 16, 2018
Stepic/TabBarRouter.swift
Outdated
| // Avoid capture of `self`. | ||
| let notificationsSection = self.notificationsSection | ||
|
|
||
| DispatchQueue.main.asyncAfter(deadline: .now() + 1) { [weak pager] in |
There was a problem hiding this comment.
Почему секунда? Почему не две? Точно не достаточно просто async?
kvld
suggested changes
Oct 17, 2018
У Как по-лучше его обозвать? |
kvld
approved these changes
Oct 17, 2018
Ostrenkiy
approved these changes
Oct 17, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-2013, #APPS-2014
Описание:
Открытие пушей и локальных нотификаций с разделением на типы и соответствующим роутингом контролируется в одном месте
NotificationsService.Поддержка локальных уведомлений до iOS 10.0 и выше, используя
LocalNotificationsService.TODO: