Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iOS 12 navigation controller crash #387

Merged
merged 4 commits into from
Oct 17, 2018
Merged

Fix iOS 12 navigation controller crash #387

merged 4 commits into from
Oct 17, 2018

Conversation

kvld
Copy link
Contributor

@kvld kvld commented Oct 16, 2018

Задача: #APPS-2097

Описание:
До этого блокирующий лоадер работал так:

  1. CourseList показывает лоадер
  2. CourseList дергает LastStepRouter
  3. LastStepRouter показывает лоадер (лоадер показан, игнорится)
  4. CourseList скрывает лоадер
  5. LastStepRouter скрывает лоадер (действие игнорится) после асинхронной подгрузки. Между 4 и 5 шагами лоадер отсутствует и можно сколько угодно раз совершать действия с курслистом

Правильный порядок:

  1. CourseList показывает лоадер
  2. CourseList дергает LastStepRouter
  3. CourseList скрывает лоадер
  4. LastStepRouter показывает лоадер
  5. LastStepRouter скрывает лоадер после асинхронной подгрузки

@kvld kvld added the main label Oct 16, 2018
@kvld kvld added this to the 1.70 milestone Oct 16, 2018
@kvld kvld requested a review from Ostrenkiy October 16, 2018 22:46
@kvld kvld merged commit d006450 into dev Oct 17, 2018
@kvld kvld deleted the fix/ios-12-multiple-view-controllers-crash branch October 17, 2018 12:22
@kvld kvld mentioned this pull request Oct 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

@Ostrenkiy Ostrenkiy Ostrenkiy approved these changes

Assignees
No one assigned
Labels
main
Projects
None yet
Milestone
1.70
Development

Successfully merging this pull request may close these issues.
3 participants
@kvld @Ostrenkiy @ivan-magda