Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.71 #398

Merged
merged 14 commits into from
Nov 2, 2018
Merged

Release 1.71 #398

merged 14 commits into from
Nov 2, 2018

Conversation

kvld
Copy link
Contributor

@kvld kvld commented Oct 31, 2018 •
edited
Loading

Release 1.71 milestone

Main & Common

  • Button title A/B: "Join" -> "Learn" #392
  • Minor fixes #393
  • Fix search results #391
  • Notifications registration services #394
  • New icon #397

Ostrenkiy and others added 8 commits October 29, 2018 18:31
@Ostrenkiy
Join -> Learn ab (#392)
e0e55e8 
* Added join -> learn a/b test

* Changed minParticipatingVersion to 1.71

* var -> let
@Ostrenkiy
Minor fixes (#393)
739a75b 
* Changed story button pressed event name

* fix continue course tooltip

* fix
@Ostrenkiy
New Search and Popular Course List query parameters (#391)
1265a15 
* Made search consistent with web & added is_popular tag to popular course list

* fix
@Ostrenkiy
Removed auth screen a/b (#395)
89596a9
@ivan-magda
Fix reloading after reconnection (#396)
4c7b6cf 
Fix reloading after reconnection for certificates and course sections screens.
@ivan-magda
New cosmic app icon (#397)
3ddd1d5 
* Update iOS app icon

* Update watch app icon

* Update iMessage app icon
@ivan-magda
Notifications registration service (#394)
c4c8c45 
* Create NotificationsRegistrationService

* Remove NotificationRequestAlertManager usages

* Recover just subscribe for the course preview

* Do not show share tooltip at the same time with permission alert

* Update streak notifications control based on permission status

* Remove StreaksAlertManager

* Reference UserActivitiesAPI for AuthNavigationViewController

* Add alert notifications analytics

* Add notification user properties analytics
@kvld
Set version to 1.71 & bump build
ccdd082
@kvld kvld requested a review from SunInJuly October 31, 2018 15:39
SunInJuly
SunInJuly approved these changes Nov 2, 2018
View reviewed changes
Copy link

@SunInJuly SunInJuly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Посмотрела, вроде все в порядке

@kvld kvld merged commit 79f9c80 into master Nov 2, 2018
@kvld kvld deleted the release/1.71 branch November 2, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunInJuly SunInJuly SunInJuly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kvld @SunInJuly @Ostrenkiy @ivan-magda