Subscribe to notifications on launch AB #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvld
reviewed
Nov 27, 2018
Stepic/Services/Notifications/Registration/NotificationsRegistrationService.swift
Outdated
Show resolved
Hide resolved
kvld
approved these changes
Nov 28, 2018
…-subscribe-on-launch
kvld
approved these changes
Nov 29, 2018
Stepic/SplitTests/ActiveTests/SubscribeNotificationsOnLaunchSplitTest.swift
Outdated
Show resolved
Hide resolved
Ostrenkiy
suggested changes
Nov 30, 2018
| if userActivity.didSolveThisWeek | ||
| && self.notificationSuggestionManager.canShowAlert(context: .streak, after: .login) { | ||
| self.streaksAlertPresentationManager.suggestStreak(streak: userActivity.currentStreak) | ||
| if !SubscribeNotificationsOnLaunchSplitTest.shouldParticipate { |
There was a problem hiding this comment.
Вот здесь, кажется, все равно надо показывать алерт, так как мы предлагаем подписаться на уведомления о стриках все-таки, а не просто дать разрешение на пуши.
Stepic/SplitTests/ActiveTests/SubscribeNotificationsOnLaunchSplitTest.swift
Outdated
Show resolved
Hide resolved
Ostrenkiy
approved these changes
Nov 30, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-2143
Описание:
Предлагаем подписаться на нотификации сразу при запуске приложения.
Кейсы, когда запрашиается доступ на нотификации:
1,6 пока не обернуты, эти действия пользователь выполняет явно и для работы этих функциональностей необходимо разрешение на получение уведомлений и поэтому мне кажется в этих случаях всегда нужно запрашивать разрешение, а остальные запросы выполняются только при определенных условиях.