Achievement popup AB #420
Merged
Achievement popup AB #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvld
suggested changes
Nov 29, 2018
kvld
reviewed
Nov 29, 2018
ivan-magda
commented
Nov 29, 2018
kvld
approved these changes
Nov 30, 2018
Completes only with the sound when is in AB test group and with alert, sound when in control group
We should always call the completion hadnler with provided .alert and .sound options, because only after pressing on the notification notifications service will handleRemoteNotification.
Ostrenkiy
approved these changes
Dec 1, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-2119
Описание:
При получении пуша об ачивке в foreground показывается попап с предложением поделиться достижением.