Ask permission to use notifications after onboarding #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvld
approved these changes
Dec 12, 2018
|
Да, откатили тест и убедились в том, что на iOS 9.0 запрос пушей происходит после онбординга, как и на iOS 10.0*. |
Ostrenkiy
reviewed
Dec 12, 2018
| @@ -64,8 +64,8 @@ struct NotificationAlertsAnalytics { | |||
| return "streak after submission - \(shownCount)" | |||
| case .personalDeadline: | |||
| return "create personal deadline" | |||
| case .abAppLaunch: | |||
| return "ab subscribe on app launch" | |||
| case .onboarding: | |||
There was a problem hiding this comment.
В будущем надо будет подумать о том, чтобы информация об ab в такие проперти не проникала и их не надо было менять.
В идеале вообще применение/откат a/b было бы делать только в паре мест, связанных с самим a/b тестом - проще и меньше потенциальных багов.
Ostrenkiy
reviewed
Dec 12, 2018
| } else { | ||
| self.notificationsRegistrationService.registerForRemoteNotifications() | ||
| } | ||
| self.notificationsRegistrationService.registerForRemoteNotifications() |
There was a problem hiding this comment.
Здесь мы это делаем чтобы предлагать пользователю в настройки перейти?
There was a problem hiding this comment.
Да, будет алерт с предложением перейти в настройки
Ostrenkiy
reviewed
Dec 12, 2018
| } else { | ||
| self.notificationsRegistrationService.registerForRemoteNotifications() | ||
| } | ||
| self.notificationsRegistrationService.registerForRemoteNotifications() |
Ostrenkiy
approved these changes
Dec 12, 2018
ivan-magda
deleted the
feature/request-notifications-permission-after-onboarding
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-2160
Описание:
Запрос разрешения на использование нотификаций после прохождения онбординга для всех пользователей.