Improved unit navigation #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ostrenkiy
approved these changes
Feb 19, 2019
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| import Foundation | |||
| import UIKit | |||
| import SVProgressHUD | |||
There was a problem hiding this comment.
Давай попробуем продумать приложение так, чтобы от блочащих экран SVProgressHUD избавиться.
(Естественно, не в рамках этого PR)
There was a problem hiding this comment.
Пока всё не перепишем, об этом рано думать :)
| // MARK: Helpers | ||
| // Remove after network layer & services refactoring | ||
|
|
||
| private func getUnitFromCacheOrNetwork(id: Unit.IdType) -> Promise<Unit?> { |
There was a problem hiding this comment.
Ох, кажется мне, что при текущей БД и возможной неуникальности объектов с одинаковыми id от фетча из кеша по id могут быть неожиданности и проблемы
There was a problem hiding this comment.
Да, но это больше для оффлайна, нам там не особо важна уникальность на самом деле
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-2206
Описание:
Переходить между юнитами можно теперь всегда, когда урок открыт в контексте unit, а не только при переходе из силлабуса.