Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.102 #565

Merged
merged 7 commits into from
Nov 19, 2019
Merged

Release 1.102 #565

merged 7 commits into from
Nov 19, 2019

Conversation

ivan-magda
Copy link
Member

Release 1.102 milestone

Features:

  • Request confirmation on downloads delete #560
  • New downloads screen #563
    • Set min value of downloaded video file size to 1 megabyte #559

Enhancements:

  • Refactor syllabus downloads #558
  • Update Firebase from 6.12.0 to 6.13.0 #561

Bug Fixes:

  • Fix crash on discussion deep link #562

ivan-magda and others added 7 commits November 13, 2019 21:06
* Set min value of file size in megabytes to 1
* Describe data flow

* Present confirmation alerts

* Add analytics
* Update Firebase from 6.12.0 to 6.13.0
* Run pod update

* Refactor rename DownloadsViewController -> LegacyDownloadsViewController

* Generate module

* Remove InputOutput

* Draft downloads fetch

* Fetch downloads data

* Display courses

* Sort courses by id

* Handle click on row

* Update Pods project settings

* Open course syllabus on click

* Update title

* Swipe to delete and support editing

* Add analytics

* Remove legacy module

* Exit editable mode on empty state
* Update SwiftLint from 0.35.0 to 0.37.0

* Format code

* Use logger

* Add the environment variable DYLD_PRINT_STATISTICS

Debug log application startup time.

* Replace class with static keyword

Subclasses can override class methods and variables, but they cannot override static methods and variables. Use static keyword where it's possible.

* Replace block.name usages with typed one

Use Block.BlockType for block type comparisons.

* Download unit

* Download section

* Report video downloading progress

Report about video, unit, and section downloading progress.

* Better update download state after starting

* Remove unused

* Ensure downloading state update

* Update cached sections units view models on unit progress update

* Remove downloads

* Cancel downloads

* Restore downloads

* Present waiting state on start downloading section

* Update section downloading state

* Delay section canceling

* Delete download tree node service

* Delete certificate spec

* Update downloads empty placeholder text

* Add missing analytics params

* Reset download's button progress on setting action state differing from downloading

* Present waiting state for units on section start downloading
@ivan-magda ivan-magda self-assigned this Nov 19, 2019
@ivan-magda ivan-magda merged commit 7e015be into master Nov 19, 2019
@ivan-magda ivan-magda deleted the release/1.102 branch November 19, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant