-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display downloaded content size in syllabus #580
Merged
ivan-magda
merged 10 commits into
feature/course-info-syllabus-downloads-improvements
from
feature/syllabus-downloads-downloaded-content-size
Nov 28, 2019
Merged
Display downloaded content size in syllabus #580
ivan-magda
merged 10 commits into
feature/course-info-syllabus-downloads-improvements
from
feature/syllabus-downloads-downloaded-content-size
Nov 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nloads-improvements' into feature/syllabus-downloads-downloaded-content-size
ivan-magda
commented
Nov 28, 2019
case .available(let isCached): | ||
case .cached(let bytesTotal): | ||
// TODO: Add label | ||
print("bytesTotal = \(bytesTotal)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget
ivan-magda
merged commit Nov 28, 2019
29c5e97
into
feature/course-info-syllabus-downloads-improvements
ivan-magda
deleted the
feature/syllabus-downloads-downloaded-content-size
branch
November 28, 2019 22:14
ivan-magda
added a commit
that referenced
this pull request
Dec 2, 2019
* Text steps as downloadable content (#577) * Update all pods * Return cached state for lessons without videos and with cached text steps * Remove all kind of steps * Display downloaded content size in syllabus (#580) * Separate available(isCached:) download state into notCached and cached(bytesTotal:) * Dispalay download size label * Refactor rename * Move megabytes in bytes formatting to helper * Display label only on cached * Create StorageUsageService * Use StorageUsageService in downloaded courses module * Provide actual sizes * Display downloaded size in section * Support cached state in syllabus header (#582) * Update download all button title * Add cached download state support for header view * Handle remove cached course action * Update syllabys header on download state changes * Fix course download state * Fix section download state not being updated on unit completion * Update unit & section download state on completion * Move units to pending state before being active
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-2552
Описание:
Добавили отображение размера скачанных файлов.