Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A/B about course text #622

Merged
merged 1 commit into from
Jan 15, 2020
Merged

A/B about course text #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Stepic.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,7 @@
2CC0754720177A2E004A6005 /* AdaptiveStatsViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CC0754620177A2E004A6005 /* AdaptiveStatsViewController.swift */; };
2CC16BA923875DE30000EF36 /* DiscussionsSkeletonView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CC16BA823875DE30000EF36 /* DiscussionsSkeletonView.swift */; };
2CC2A78E235DE26700B2DC44 /* DiscussionsLoadMoreTableViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CC2A78D235DE26700B2DC44 /* DiscussionsLoadMoreTableViewCell.swift */; };
2CC3093D23CF2740005F49C1 /* AboutCourseStringSplitTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CC3093C23CF273F005F49C1 /* AboutCourseStringSplitTest.swift */; };
2CC3518A1F682A02004255B6 /* SocialAuthCollectionViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CC351881F682A02004255B6 /* SocialAuthCollectionViewCell.swift */; };
2CC3518B1F682A02004255B6 /* SocialAuthCollectionViewCell.xib in Resources */ = {isa = PBXBuildFile; fileRef = 2CC351891F682A02004255B6 /* SocialAuthCollectionViewCell.xib */; };
2CC3518F1F682B6C004255B6 /* SocialAuthHeaderView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CC3518E1F682B6C004255B6 /* SocialAuthHeaderView.swift */; };
Expand Down Expand Up @@ -1772,6 +1773,7 @@
2CC0754620177A2E004A6005 /* AdaptiveStatsViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AdaptiveStatsViewController.swift; sourceTree = "<group>"; };
2CC16BA823875DE30000EF36 /* DiscussionsSkeletonView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DiscussionsSkeletonView.swift; sourceTree = "<group>"; };
2CC2A78D235DE26700B2DC44 /* DiscussionsLoadMoreTableViewCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DiscussionsLoadMoreTableViewCell.swift; sourceTree = "<group>"; };
2CC3093C23CF273F005F49C1 /* AboutCourseStringSplitTest.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AboutCourseStringSplitTest.swift; sourceTree = "<group>"; };
2CC351851F6827BE004255B6 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/Auth.storyboard; sourceTree = "<group>"; };
2CC351881F682A02004255B6 /* SocialAuthCollectionViewCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SocialAuthCollectionViewCell.swift; sourceTree = "<group>"; };
2CC351891F682A02004255B6 /* SocialAuthCollectionViewCell.xib */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.xib; path = SocialAuthCollectionViewCell.xib; sourceTree = "<group>"; };
Expand Down Expand Up @@ -3776,6 +3778,7 @@
2C37968421ABED9500BC7E62 /* ActiveTests */ = {
isa = PBXGroup;
children = (
2CC3093C23CF273F005F49C1 /* AboutCourseStringSplitTest.swift */,
08421BCA21764FC400E8A81B /* ActiveSplitTestsContainer.swift */,
);
path = ActiveTests;
Expand Down Expand Up @@ -6666,6 +6669,7 @@
2CE8391320C8102300FE3672 /* AchievementBadgeView.swift in Sources */,
08F4859A1C57868E000165AA /* TextReply.swift in Sources */,
2C4BE7E0221328E700AEAC34 /* CourseReview+CoreDataProperties.swift in Sources */,
2CC3093D23CF2740005F49C1 /* AboutCourseStringSplitTest.swift in Sources */,
080E1ACC212571D9006B58A9 /* StoryPartViewFactory.swift in Sources */,
0828FF831BC800C0000AFEA7 /* JSONSerializable.swift in Sources */,
086D5B3F20127A25000F7715 /* Tooltip.swift in Sources */,
Expand Down
23 changes: 23 additions & 0 deletions Stepic/Analytics/SplitTests/ActiveTests/AboutCourseStringSplitTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import Foundation

final class AboutCourseStringSplitTest: SplitTestProtocol {
typealias GroupType = Group

static let identifier = "about_course_string"
static let minParticipatingStartVersion = "1.109"

var currentGroup: Group
var analytics: ABAnalyticsServiceProtocol

init(currentGroup: Group, analytics: ABAnalyticsServiceProtocol) {
self.currentGroup = currentGroup
self.analytics = analytics
}

enum Group: String, SplitTestGroupProtocol {
case control
case test

static var groups: [Group] = [.control, .test]
}
}
2 changes: 1 addition & 1 deletion Stepic/Analytics/SplitTests/ActiveTests/ActiveSplitTestsContainer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ final class ActiveSplitTestsContainer {
)

static func setActiveTestsGroups() {
// There are no A/B tests now
self.splitTestingService.fetchSplitTest(AboutCourseStringSplitTest.self).setSplitTestGroup()
}
}
18 changes: 17 additions & 1 deletion ...c/Sources/Modules/CourseInfoSubmodules/CourseInfoTabInfo/CourseInfoTabInfoPresenter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ protocol CourseInfoTabInfoPresenterProtocol {
final class CourseInfoTabInfoPresenter: CourseInfoTabInfoPresenterProtocol {
weak var viewController: CourseInfoTabInfoViewControllerProtocol?

private let splitTestingService = SplitTestingService(
analyticsService: AnalyticsUserProperties(),
storage: UserDefaults.standard
)

func presentCourseInfo(response: CourseInfoTabInfo.InfoLoad.Response) {
var viewModel: CourseInfoTabInfo.InfoLoad.ViewModel

Expand Down Expand Up @@ -37,11 +42,22 @@ final class CourseInfoTabInfoPresenter: CourseInfoTabInfoPresenterProtocol {
)
: nil

let aboutText: String = {
var text = course.summary
if AboutCourseStringSplitTest.shouldParticipate {
let splitTest = self.splitTestingService.fetchSplitTest(AboutCourseStringSplitTest.self)
if case .test = splitTest.currentGroup {
text = course.courseDescription
}
}
return text.trimmingCharacters(in: .whitespaces)
}()

return CourseInfoTabInfoViewModel(
author: self.makeFormattedAuthorText(authors: course.authors),
introVideoURL: self.makeIntroVideoURL(course: course),
introVideoThumbnailURL: URL(string: course.introVideo?.thumbnailURL ?? ""),
aboutText: course.summary.trimmingCharacters(in: .whitespaces),
aboutText: aboutText,
requirementsText: course.requirements.trimmingCharacters(in: .whitespaces),
targetAudienceText: course.audience.trimmingCharacters(in: .whitespaces),
timeToCompleteText: self.makeFormattedTimeToCompleteText(timeToComplete: course.timeToComplete),
Expand Down