New catalog course list pagination #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ivan-magda
added a commit
that referenced
this pull request
Dec 21, 2020
* New catalog API (#822) * Add CatalogBlock model * Add CatalogBlocksAPI * Add persistence * Add services * Delete unused * New catalog container view (#824) * Add header view * Add container view * New catalog full course lists (#831) * Generate module * Load catalog blocks * Display full_course_lists catalog block first item * New catalog simple course lists (#832) * Generate module * Load course list data * Display course list data * Colorize * Fix layout dimensions * Present course list in fullscreen * New catalog authors (#838) * Generate module * Load course list data * Draft display course list data * Add ratings views * Format authors count with localized and pluralized suffix * Fix format followers count with localized and pluralized suffix * Add shadow * Fix layout dimensions * Present author profile on click * Add skeleton view * Delete obsolete submodules from catalog Deletes tags & collection & popularCourses submodules. * Use mobile,ios platform in CatalogBlocksAPI * Set version to 1.152 & bump build * New catalog course list pagination (#846) * Collection+group(by:) * Update CatalogBlockCourseListNetworkService fetch request * Update DeepLinkCourseListNetworkService fetch request * New catalog simple course lists grid (#852) * Add layout type support * Split view & data source & delegate * Add section header view * Implement layout * Handle section header tap * Fix images * Clean up * New catalog similar course lists (#853) * Fix SimpleCourseListDefaultWidgetView constraints * Update model * Initial context support for AuthorsCourseList * Course list refresh similar course lists * Initial context support for SimpleCourseList * Similar course lists presentation draft * Fix scroll * Add localizable * Handle taps on similar items * Load all courses * Refactor rename * New catalog prepare (#857) * Use LeftAlignedCollectionViewFlowLayout for simple_course_lists_grid * Add shadow for course widget * Fix spacing * Update fonts & text colors * Bump build * Handle error & empty states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTrack task: #APPS-3090
Description: