Fixed annoying selection of initial step with bad connection #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvld
suggested changes
Aug 18, 2017
Stepic/LessonPresenter.swift
Outdated
| @@ -30,6 +30,9 @@ class LessonPresenter { | |||
| fileprivate var unitId: Int? | |||
| fileprivate var context: StepsControllerPresentationContext = .unit | |||
|
|
|||
| var stepsAPI = ApiDataDownloader.steps | |||
There was a problem hiding this comment.
А зачем нам в этом классе зависеть ещё и от ApiDataDownloader?
There was a problem hiding this comment.
Это default value. Думаешь стоит убрать?
|
Fixed |
kvld
approved these changes
Aug 21, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1405
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
При медленном соединении после обновления урока пользователь не перекидывается на первый таб.
Описание:
Добавил немного зависимостей в
LessonPresenter, а так же исправил эту ошибку. Возможно, мы также этим пофиксим львиную долю крашей, которые приходятся на несвоевременный выбор таба.