Adaptive scoreboard #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ostrenkiy
suggested changes
Aug 18, 2017
Stepic/SubmissionsAPI.swift
Outdated
| @@ -12,6 +12,14 @@ import SwiftyJSON | |||
|
|
|||
| class SubmissionsAPI: APIEndpoint { | |||
There was a problem hiding this comment.
Думаю, лучше унаследовать SubmissionsAPI и сделать класс AdaptiveSubmissionsAPI. Там ты сможешь просто модифицировать параметры и вызывать super.retrieve() или super.create(). Возможно, стоит добавить в сигнатуру методов параметр parameters: Parameters = [:], чтобы было совсем удобно и расширяемо.
| } | ||
|
|
||
| fileprivate func loadNamesFromFiles() { | ||
| func readTxtFile(name: String) -> [String] { |
There was a problem hiding this comment.
Точно в txt хранить - лучший формат?
Почему бы не в plist? Так было бы более human readable.
|
@Ostrenkiy можно смотреть снова. |
|
ok, сейчас посмотрю |
Ostrenkiy
approved these changes
Aug 21, 2017
Ostrenkiy
approved these changes
Aug 23, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1387, #APPS-1385
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Добавлен ТОП-10 пользователей в адаптивном приложении
Описание:
Таблицы рейтинга (всё время/7 дней) для адаптивного приложения на третьей вкладке страницы со статистикой.
SubmissionsAPI переделан для работы с отдельным бекендом, который собирает рейтинги.
TODO