Fix issue of false positive VOG032 for non ValueObject #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is not ValueObject
alikoncak
approved these changes
Apr 9, 2025
Owner
|
Thanks for the PR! Apologies for the false positives. I'll include this in the next release, which will hopefully be within a week or so. |
SteveDunn
approved these changes
May 21, 2025
Owner
SteveDunn
left a comment
SteveDunn
left a comment
There was a problem hiding this comment.
LGTM! Thanks very much for the contribution, and apologies it's been such a long time - unforuntately, my time is very limited at the moment.
Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a false positive for DoNotThrowFromUserCode analyser check when inside a class that contains an attribute that isn't ValueObject.