Issue #2785: fix — ignore domains ending with a dot.

StevenBlack · Dec 17, 2024 · 080d276 · 080d276
1 parent 7c8c1fb
commit 080d276
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/testUpdateHostsFile.py b/testUpdateHostsFile.py
@@ -846,6 +846,7 @@ def test_no_match(self):
             "0.3.4.5 example.org/hello/world",
             "0.0.0.0 https",
             "0.0.0.0 https..",
+            "0.0.0.0 foo.",
         ]:
             self.assertEqual(normalize_rule(rule, **kwargs), (None, None))
 

diff --git a/updateHostsFile.py b/updateHostsFile.py
@@ -1129,15 +1129,19 @@ def belch_unwanted(unwanted: str) -> Tuple[None, None]:
             is_ip(hostname)
             or re.search(static_ip_regex, hostname)
             or "." not in hostname
-            or "/" in hostname
             or ".." in hostname
+            or "." in hostname[-1]
+            or "/" in hostname
             or ":" in hostname
         ):
             # Example: 0.0.0.0 127.0.0.1
 
             # If the hostname is:
             #   - an IP - or looks like it,
             #   - doesn't contain dots, or
+            #   - contains repeated dots,
+            #   - ends in a dot, or
+            #   - contains a slash, or
             #   - contains a colon,
             # we don't want to normalize it.
             return belch_unwanted(rule)