Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more gvt2 domains from chrome #1746

Closed
wants to merge 1 commit into from
Closed

Added more gvt2 domains from chrome #1746

wants to merge 1 commit into from

Conversation

erdh
Copy link

@erdh erdh commented Aug 26, 2021

While I am using Google Chrome, I noticed some gvt.com domains are not blocked by pi-hole, so I added gvt.com domains that are not in this list. I haven't experienced any sites not working properly with the changes I made. @StevenBlack please review and merge if it is okay to go.

@welcome
Copy link

welcome bot commented Aug 26, 2021

Thank you for submitting this pull request! We’ll get back to you as soon as we can!

@StevenBlack
Copy link
Owner

Hi Erdem @erdh thank you for this.

This repo generates hosts files from data. So new hosts have to be added to data, not the end-product of the pipeline.

Another curator sources our gvt2.com domains. @jawz101 would you consider adding these to your list, so they come from a common source?

0.0.0.0 beacons3.gvt2.com
0.0.0.0 beacons4.gvt2.com
0.0.0.0 beacons5.gvt2.com
0.0.0.0 e2clock.gcp.gvt2.com

@dnmTX
Copy link
Contributor

dnmTX commented Aug 26, 2021

Search

jawz101 added a commit to AdAway/adaway.github.io that referenced this pull request Aug 26, 2021
@jawz101
Copy link

jawz101 commented Aug 26, 2021

I just removed all of the ones I had on the list. I'm not sure what they are except they are Google entries and I'd rather not break something I don't know about. It doesn't look like they are necessarily related to mobile app traffic but I don't know. @dnmTX are those url's that are associated with those domains?

@dnmTX
Copy link
Contributor

dnmTX commented Aug 26, 2021

@jawz101 they all are baked in domains with one sole purpose only: COLLECT
You really shouldn't be worry that by blocking them it will brake something....besides the obvious 😉
Check those links just to set your mind at ease(all baked in,no way to remove or disable):
https://source.chromium.org/chromium/chromium/src/+/main:components/domain_reliability/baked_in_configs/c_play_google_com.json
https://source.chromium.org/chromium/chromium/src/+/main:components/domain_reliability/baked_in_configs/c_youtube_com.json
https://source.chromium.org/chromium/chromium/src/+/main:components/domain_reliability/baked_in_configs/c_2mdn_net.json
https://source.chromium.org/chromium/chromium/src/+/main:components/domain_reliability/baked_in_configs/google-analytics_com.json

P.S. Actually it's all part of Google's domain reliability feature which on desktop is possible to disable it but i'm not sure when it comes to mobile platforms.

@jawz101 just don't add clients2.google.com cause it's associated with user's account and many things could break !!!!

@erdh
Copy link
Author

erdh commented Aug 26, 2021

@dnmTX I just came across these domains from query logs of my laptop, I don't remeber seeing any of these domains on query list of my android telephone and tablet. I assume this is spesific for Google's spesific apps like Chrome, I try to use less google services on my android devices so thats why my devices didn't query them.

@dnmTX
Copy link
Contributor

dnmTX commented Aug 26, 2021

Erdem @erdh just run your Chrome/Cromium with --disable-domain-reliability command line switch which should disable that service completely.

@jawz101
Copy link

jawz101 commented Aug 26, 2021

yeah I think I'm going to leave them out from the Adaway list at least. Looking on VirusTotal, I did not see that Android apk's have not been detected to communicate w/ those domains- at least in their sandbox environment.

I guess I just googled Google Domain Reliability and Brave Browser as well as Yandex gave a little explaination of what it is as well. We can classify it as tracking but since it doesn't deal with mobile, I'm going to keep it off of the adaway list and if another source list wants to address it that is fine . If anything, it sounds like something that could be a browser/site standard that could let sites know when users are unable to visit their site so they can figure out if there is some sort of outage somewhere. I've been a little more lenient on infrastructure or fraud prevention things like that more and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants