-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more gvt2 domains from chrome #1746
Conversation
Thank you for submitting this pull request! We’ll get back to you as soon as we can! |
Hi Erdem @erdh thank you for this. This repo generates hosts files from data. So new hosts have to be added to data, not the end-product of the pipeline. Another curator sources our
|
I just removed all of the ones I had on the list. I'm not sure what they are except they are Google entries and I'd rather not break something I don't know about. It doesn't look like they are necessarily related to mobile app traffic but I don't know. @dnmTX are those url's that are associated with those domains? |
@jawz101 they all are baked in domains with one sole purpose only: COLLECT P.S. Actually it's all part of Google's domain reliability feature which on desktop is possible to disable it but i'm not sure when it comes to mobile platforms. @jawz101 just don't add |
@dnmTX I just came across these domains from query logs of my laptop, I don't remeber seeing any of these domains on query list of my android telephone and tablet. I assume this is spesific for Google's spesific apps like Chrome, I try to use less google services on my android devices so thats why my devices didn't query them. |
Erdem @erdh just run your Chrome/Cromium with |
yeah I think I'm going to leave them out from the Adaway list at least. Looking on VirusTotal, I did not see that Android apk's have not been detected to communicate w/ those domains- at least in their sandbox environment. I guess I just googled Google Domain Reliability and Brave Browser as well as Yandex gave a little explaination of what it is as well. We can classify it as tracking but since it doesn't deal with mobile, I'm going to keep it off of the adaway list and if another source list wants to address it that is fine . If anything, it sounds like something that could be a browser/site standard that could let sites know when users are unable to visit their site so they can figure out if there is some sort of outage somewhere. I've been a little more lenient on infrastructure or fraud prevention things like that more and more. |
While I am using Google Chrome, I noticed some gvt.com domains are not blocked by pi-hole, so I added gvt.com domains that are not in this list. I haven't experienced any sites not working properly with the changes I made. @StevenBlack please review and merge if it is okay to go.