Invert logo color for dark theme #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this pull request! We’ll get back to you as soon as we can! |
|
Thank you for this Sean @Sea-n Following your link, when I switch GitHub to dark mode, this is what I see. Observe: the "HOSTS" text is non-contrasting. What am I doing wrong? What's missing in this PR? 
|
|
Sorry Sean @Sea-n my mistake. Nevermind 😄. This is good! Merging! |
|
Congratulations on merging your first pull request here! 🎉🎉🎉 You are now in our list of contributors. Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can preview the result here:
https://github.com/Sea-n/StevenBlack-hosts#readme
And changed the Image path in README to relative path.