Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-way Binding Support #22

Merged
merged 6 commits into from
Jan 11, 2020
Merged

Conversation

StevenLambion
Copy link
Owner

This PR adds a convenient API to provide better support of SwiftUI views that use Binding<_> for their arguments. It combines a state value with a setter-based action that is expected to update it.

Work Performed

  • Added StateBinder
  • Added new API to Connectable and ParameterizedConnectable to include StateBinder when mapping the application state to a view.

@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #22   +/-   ##
====================================
  Coverage      60%   60%           
====================================
  Files          15    15           
  Lines         410   410           
====================================
  Hits          246   246           
  Misses        164   164
Impacted Files Coverage Δ
Sources/SwiftDux/State/OrderedState.swift 81.45% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07babd...f47bc40. Read the comment docs.

@StevenLambion StevenLambion merged commit 83be78d into master Jan 11, 2020
@StevenLambion StevenLambion deleted the features/2-way-binding-support branch November 10, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants