Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ActionDispatcher Callable. #32

Merged
merged 7 commits into from
Feb 8, 2020

Conversation

StevenLambion
Copy link
Owner

@StevenLambion StevenLambion commented Feb 7, 2020

Xcode 11.4 now comes with Swift 5.2, adding the highly anticipated callAsFunction feature. This first PR covers the ActionDispatcher. The next PR will cover middleware and reducers.

Github does not support Xcode 11.4 or Swift 5.2 yet, so the workflow will fail.

Work Performed

  • Removed deprecated APIs
  • Added predefined callAsFunction to ActionDispatcher protocol.
  • Removed ModifiedAction and the sentAction parameter to simplify codebase.
  • Replaced StoreActionDispatcher with StoreProxy.

@StevenLambion StevenLambion merged commit 09139f1 into swift-5.2 Feb 8, 2020
@StevenLambion StevenLambion deleted the features/call-ActionDispatcher-as-function branch November 10, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant