Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Middleware and Reducer pipeline #52

Merged
merged 5 commits into from
Nov 21, 2020

Conversation

StevenLambion
Copy link
Owner

@StevenLambion StevenLambion commented Nov 20, 2020

Work Performed

  • Consolidated chaining methods for actions.
  • Removed next(_:) method from StoreProxy.
  • Middleware now returns an optional Action instead of calling next(_:) off of the StoreProxy.
  • Added the ReducerMiddleware so that the reducing step can be a part of the middleware pipeline.
  • Fixed a circular dependency in the StoreProxy given to middleware.
  • Replaced the asynchronous init of ActionPlan with one that returns a publisher to simplify the code.
  • Removed the completion handler from ActionSubscriber.
  • Fixed a bug introduced in iOS 14 that caused a crash related to the onReceive view modifier.

Using if-else banching in the Group also caused it to crash. Always having the EmptyView appears to fix it. The crash occurs directly before onReceive calls its closure.
@codecov-io
Copy link

codecov-io commented Nov 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (2.x@0deffd3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             2.x      #52   +/-   ##
======================================
  Coverage       ?   80.26%           
======================================
  Files          ?       25           
  Lines          ?      456           
  Branches       ?        0           
======================================
  Hits           ?      366           
  Misses         ?       90           
  Partials       ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0deffd3...420e4af. Read the comment docs.

@StevenLambion StevenLambion merged commit 132b568 into 2.x Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants