Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Release v1.0.0 into main branch #103

Closed
wants to merge 32 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
dbcf272
Remove RForcecom Dependency
StevenMMortimer Jul 3, 2021
bdb2941
Remove RForcecom Dependency
StevenMMortimer Jul 3, 2021
c0db731
Fix Bug in Parsing OwnerChangeOptions
StevenMMortimer Jul 3, 2021
9cdbd2d
Update Display of Lifecycle tags in Documentation
StevenMMortimer Jul 3, 2021
f415b49
Allow guess_types in sf_run_report and fix date and datetime column bug
StevenMMortimer Jul 3, 2021
275c38f
Fix bug where datetime fields break Bulk 2.0 recordsets
StevenMMortimer Jul 3, 2021
f6c5a51
Update NEWS.md with new bug fixes
StevenMMortimer Jul 3, 2021
dbd9a09
Fix roxygen syntax error in in sf_auth documentation
StevenMMortimer Jul 3, 2021
7c7e5e5
Further remove RForcecom references to pass build
StevenMMortimer Jul 3, 2021
24d8272
In Bulk APIs use all values in column to guess type
StevenMMortimer Jul 4, 2021
6b8442f
Fix deprecated argument name in write_csv
StevenMMortimer Jul 4, 2021
4377e0b
Update possible versions list in tests
StevenMMortimer Jul 4, 2021
5e948b9
Update Bulk 2.0 grandparent query test
StevenMMortimer Jul 4, 2021
f2cf235
Document changes because of readr
StevenMMortimer Jul 4, 2021
5efa100
Fix bug after write_csv change
StevenMMortimer Jul 4, 2021
c5ce782
Bump version
StevenMMortimer Jul 4, 2021
484bbf1
Bump version in READMEs
StevenMMortimer Jul 4, 2021
b5da775
Fix notes from win-builder
StevenMMortimer Jul 4, 2021
7419014
Update NEWS to reflect change in package lifecycle
StevenMMortimer Jul 4, 2021
80dac32
Bump to version 1.0.0
StevenMMortimer Jul 4, 2021
8aeb8c4
Add to wordlist as flagged by win-builder
StevenMMortimer Jul 4, 2021
99750fc
Bump the date by one day
StevenMMortimer Jul 4, 2021
6b2f4b9
Add deprecation notices for bind_using_character_cols and path
StevenMMortimer Jul 4, 2021
f4f84ac
Remove reference to bind_using_character_cols
StevenMMortimer Jul 4, 2021
4ddc6fc
Fix bug in reference to text/csv httr responses from Bulk 1.0 API
StevenMMortimer Jul 4, 2021
89bd883
Trigger more comprehensive checks when associated with release branch
StevenMMortimer Jul 4, 2021
a4805ac
Enable manual triggering of individual workflows
StevenMMortimer Jul 4, 2021
5d7b4bd
Upgrade the default API version to 52.0
StevenMMortimer Jul 4, 2021
de11455
Turn off token check verbose messages
StevenMMortimer Jul 4, 2021
74a99e3
Attempt to satisfy Windows Build Error
StevenMMortimer Jul 4, 2021
c171360
Fix error in Vignettes building on Windows due to knitr bug
StevenMMortimer Jul 4, 2021
c3a8f4b
Clarification in NEWS
StevenMMortimer Jul 4, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/main-01-pkgdown.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: Build pkgdown site

on:
workflow_dispatch:
inputs:
trigger_next:
description: 'Whether to run the subsequent workflows after triggering this one manully.'
required: false
default: false
push:
branches: main

Expand Down Expand Up @@ -74,7 +80,7 @@ jobs:
Rscript -e 'pkgdown::deploy_to_branch(new_process = FALSE)'

- name: Trigger next workflow
if: success()
if: ${{ (github.event_name != 'workflow_dispatch' && success()) || (github.event_name == 'workflow_dispatch' && github.event.inputs.trigger_next && success()) }}
uses: peter-evans/repository-dispatch@v1
with:
token: ${{ secrets.REPO_GHA_PAT }}
Expand All @@ -83,7 +89,7 @@ jobs:
client-payload: '{"ref": "${{ github.ref }}", "sha": "${{ github.sha }}"}'

- name: Set final R-CMD-check status
if: failure()
if: ${{ (github.event_name != 'workflow_dispatch' && failure()) }}
uses: peter-evans/repository-dispatch@v1
with:
token: ${{ secrets.REPO_GHA_PAT }}
Expand Down
14 changes: 10 additions & 4 deletions .github/workflows/main-02-test-coverage.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
name: Test coverage

on:
workflow_dispatch:
inputs:
trigger_next:
description: 'Whether to run the subsequent workflows after triggering this one manully.'
required: false
default: false
repository_dispatch:
types: [main-02-test-coverage]
schedule:
# Execute monthly at 9AM UTC (5AM EDT (during daylight savings), otherwise 4AM)
- cron: '0 9 1 * *'
# Execute monthly at 9AM UTC (5AM ET during daylight savings, otherwise 4AM)
- cron: '0 9 1 * *'

jobs:
test-coverage:
Expand Down Expand Up @@ -72,7 +78,7 @@ jobs:
shell: Rscript {0}

- name: Trigger next workflow
if: success()
if: ${{ (github.event_name != 'workflow_dispatch' && success()) || (github.event_name == 'workflow_dispatch' && github.event.inputs.trigger_next && success()) }}
uses: peter-evans/repository-dispatch@v1
with:
token: ${{ secrets.REPO_GHA_PAT }}
Expand All @@ -81,7 +87,7 @@ jobs:
client-payload: '{"ref": "${{ github.ref }}", "sha": "${{ github.sha }}"}'

- name: Set final R-CMD-check status
if: failure()
if: ${{ (github.event_name != 'workflow_dispatch' && failure()) }}
uses: peter-evans/repository-dispatch@v1
with:
token: ${{ secrets.REPO_GHA_PAT }}
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/main-03-R-CMD-check-mac.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: R-CMD-check on Mac

on:
workflow_dispatch:
inputs:
trigger_next:
description: 'Whether to run the subsequent workflows after triggering this one manully.'
required: false
default: false
repository_dispatch:
types: [main-03-R-CMD-check-mac]

Expand Down Expand Up @@ -92,7 +98,7 @@ jobs:
path: check

- name: Trigger next workflow
if: success()
if: ${{ (github.event_name != 'workflow_dispatch' && success()) || (github.event_name == 'workflow_dispatch' && github.event.inputs.trigger_next && success()) }}
uses: peter-evans/repository-dispatch@v1
with:
token: ${{ secrets.REPO_GHA_PAT }}
Expand All @@ -101,7 +107,7 @@ jobs:
client-payload: '{"ref": "${{ github.ref }}", "sha": "${{ github.sha }}"}'

- name: Set final R-CMD-check status
if: failure()
if: ${{ (github.event_name != 'workflow_dispatch' && failure()) }}
uses: peter-evans/repository-dispatch@v1
with:
token: ${{ secrets.REPO_GHA_PAT }}
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/main-04-R-CMD-check-windows.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: R-CMD-check on Windows

on:
workflow_dispatch:
inputs:
trigger_next:
description: 'Whether to run the subsequent workflows after triggering this one manully.'
required: false
default: false
repository_dispatch:
types: [main-04-R-CMD-check-windows]

Expand Down Expand Up @@ -92,7 +98,7 @@ jobs:
path: check

- name: Trigger next workflow
if: success()
if: ${{ (github.event_name != 'workflow_dispatch' && success()) || (github.event_name == 'workflow_dispatch' && github.event.inputs.trigger_next && success()) }}
uses: peter-evans/repository-dispatch@v1
with:
token: ${{ secrets.REPO_GHA_PAT }}
Expand All @@ -101,7 +107,7 @@ jobs:
client-payload: '{"ref": "${{ github.ref }}", "sha": "${{ github.sha }}"}'

- name: Set final R-CMD-check status
if: failure()
if: ${{ (github.event_name != 'workflow_dispatch' && failure()) }}
uses: peter-evans/repository-dispatch@v1
with:
token: ${{ secrets.REPO_GHA_PAT }}
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/main-05-R-CMD-check-linux.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: R-CMD-check on Linux

on:
workflow_dispatch:
inputs:
trigger_next:
description: 'Whether to run the subsequent workflows after triggering this one manully.'
required: false
default: false
repository_dispatch:
types: [main-05-R-CMD-check-linux]

Expand Down Expand Up @@ -92,7 +98,7 @@ jobs:
path: check

- name: Set final R-CMD-check status
if: always()
if: ${{ (github.event_name != 'workflow_dispatch') || (github.event_name == 'workflow_dispatch' && github.event.inputs.trigger_next) }}
uses: peter-evans/repository-dispatch@v1
with:
token: ${{ secrets.REPO_GHA_PAT }}
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/main-06-R-CMD-check-final.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: R-CMD-check

on:
workflow_dispatch:
inputs:
force_failure:
description: 'A backdoor trigger to force the final R CMD Check status to failed.'
required: true
default: false
repository_dispatch:
types: [main-06-R-CMD-check-final]

Expand All @@ -12,5 +18,6 @@ jobs:
steps:

- name: Convey final status of all R-CMD-check workflows
if: ${{ !github.event.client_payload.success }}
if: ${{ (github.event_name != 'workflow_dispatch' && !github.event.client_payload.success) || (github.event_name == 'workflow_dispatch' && github.event.inputs.force_failure) }}
run: exit 1

37 changes: 23 additions & 14 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: salesforcer
Title: An Implementation of 'Salesforce' APIs Using Tidy Principles
Version: 0.2.2.9000
Date: 2020-09-12
Version: 1.0.0
Date: 2021-07-04
Description: Functions connecting to the 'Salesforce' Platform APIs (REST, SOAP,
Bulk 1.0, Bulk 2.0, Metadata, Reports and Dashboards)
<https://trailhead.salesforce.com/en/content/learn/modules/api_basics/api_basics_overview>.
Expand All @@ -11,12 +11,23 @@ Description: Functions connecting to the 'Salesforce' Platform APIs (REST, SOAP,
API documentation and this package's website
<https://stevenmmortimer.github.io/salesforcer/> for more information,
documentation, and examples.
Authors@R: c(
person(c("Steven", "M."), "Mortimer", , "mortimer.steven.m@gmail.com", c("aut", "cre")),
person("Takekatsu", "Hiramura", , "thira@plavox.info", c("ctb")),
person("Jennifer", "Bryan", , "jenny@rstudio.com", c("ctb", "cph")),
person("Joanna", "Zhao", , "joanna.zhao@alumni.ubc.ca", c("ctb", "cph"))
)
Authors@R:
c(person(given = c("Steven", "M."),
family = "Mortimer",
role = c("aut", "cre"),
email = "mortimer.steven.m@gmail.com"),
person(given = "Takekatsu",
family = "Hiramura",
role = "ctb",
email = "thira@plavox.info"),
person(given = "Jennifer",
family = "Bryan",
role = c("ctb", "cph"),
email = "jenny@rstudio.com"),
person(given = "Joanna",
family = "Zhao",
role = c("ctb", "cph"),
email = "joanna.zhao@alumni.ubc.ca"))
License: MIT + file LICENSE
URL: https://github.com/StevenMMortimer/salesforcer
BugReports: https://github.com/StevenMMortimer/salesforcer/issues
Expand All @@ -32,6 +43,7 @@ Imports:
tibble (>= 3.0.3),
readr (>= 1.3.1),
lubridate (>= 1.7.8),
anytime (>= 0.3.9),
rlang (>= 0.4.7),
httr (>= 1.4.1),
curl (>= 4.3),
Expand All @@ -46,19 +58,16 @@ Imports:
lifecycle (>= 0.2.0)
Suggests:
knitr,
rmarkdown,
testthat,
spelling,
rmarkdown,
here,
microbenchmark,
ggplot2,
sessioninfo,
RForcecom
VignetteBuilder:
knitr
sessioninfo
VignetteBuilder: rmarkdown
ByteCompile: true
Encoding: UTF-8
Language: en-US
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.1
3 changes: 3 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,8 @@ importFrom(XML,xmlSApply)
importFrom(XML,xmlSize)
importFrom(XML,xmlToList)
importFrom(XML,xmlValue)
importFrom(anytime,anydate)
importFrom(anytime,anytime)
importFrom(base64enc,base64encode)
importFrom(curl,form_data)
importFrom(curl,form_file)
Expand Down Expand Up @@ -359,6 +361,7 @@ importFrom(purrr,transpose)
importFrom(readr,col_character)
importFrom(readr,col_guess)
importFrom(readr,cols)
importFrom(readr,locale)
importFrom(readr,parse_datetime)
importFrom(readr,read_csv)
importFrom(readr,type_convert)
Expand Down
43 changes: 39 additions & 4 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,51 @@
## salesforcer 0.2.2.9000
## salesforcer 1.0.0

### Dependencies

* None yet.
* Increase the package's default Salesforce API version to 52.0 (Summer '21).

* Remove uses of {RForcecom} after it was removed from CRAN on 6/9/2021 (#101)

* Remove LazyData option in DESCRIPTION since `data()` is not utilized

* Deprecate argument in `sf_write_csv()` from `path` to `file` as was done in
{readr} v1.4.0.

* Deprecate argument `bind_using_character_cols` because we will always need
to bind as character and then parse if `guess_types=TRUE`. Per comments in
tidyverse/readr#588 and tidyverse/readr#98, we must read all of the data as
character first and then use `type_convert()` to ensure that we use all values
in the column to guess the type. The default for `read_csv()` is to only use
the first 1,000 rows and its `guess_max` argument cannot be set to `Inf`.

* Change lifecycle status from "Maturing" to "Status" per the retirement of
"Maturing" in the {lifecycle} package. The documentation notes:

> Previously we used as maturing for functions that lay somewhere between experimental and stable. We stopped using this stage because, like questioning, it’s not clear what actionable information this stage delivers.

In addition, the lifecycle guidance states that experimental packages have
version numbers less than 1.0.0 and may have major changes in its future.
The {salesforcer} package has achieved a stable state with core
functionality implemented and a focus on backwards compatibility due to the
volume of users.

### Features

* None yet.
* Improve documentation to retrieve the access token or session ID after
authentication (#97)

* Improve parsing of Bulk API query recordsets from CSV where all values
in the column will be used to guess the type instead of the first 1000.

### Bug fixes

* None yet.
* Generalize the date and datetime parsing mechanism, such that, reports with
date and datetime fields are not returned as NA (#93)

* Fix the format of the `OwnerChangeOptions` header so it is accepted (#94)

* Fix bug that caused Bulk 2.0 calls to crash when the results had datetime
fields in the recordset (#95)

---

Expand Down
Loading