Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error codes are not present in ErrorException #160

Closed
vostreltsov opened this issue Jan 26, 2021 · 1 comment
Closed

Error codes are not present in ErrorException #160

vostreltsov opened this issue Jan 26, 2021 · 1 comment

Comments

@vostreltsov
Copy link
Contributor

vostreltsov commented Jan 26, 2021

Here:

throw new ErrorException($e->getMessage());

the error codes 503/429/413 are omitted.

Please correct me if I am wrong, but having error codes preserved, one could check if updating proxy options (i.e. using a new TOR identity) helps. That's exactly my case right now. Could do a pull-request if my proposal is approved.

BTW thanks for a handy library.

@Stichoza
Copy link
Owner

Agreed. Currently the error code is only present in the error message itself. I can add it quickly but send a PR if you already have the patch, would be nice to grow the list of contributors 👍🏼

Stichoza added a commit that referenced this issue Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants