Laxpc standard analysis #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteobachetti
requested changes
Jul 15, 2025
There was a problem hiding this comment.
Thanks @yashbhargava1992 !
A few quick comments before a more thorough review:
- I think you can create an entry on Zenodo yourself to share the sample data. It will be easier, more robust, and there will be a better recognition of your contribution.
1a) Instead of asking the user to change the path to the directory, instruct them to move the data in the notebook directory instead. This will be cleaner I think.
- The spikes in the periodogram seem mainly the different harmonics of the pulsar, not the window function. They are all at multiples of ~30 Hz, right?
Changed alias--> harmonic
… os lib commands to standardise the paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Jupyter Notebook tutorial to analyse the LAXPC data.
The data is currently hosted on my google drive. If the notebook works, we can move it to a different data repo