Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button in wrong language #1544

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

t71rs
Copy link
Contributor

@t71rs t71rs commented Jul 8, 2024

Made File Input Form translatable

The File Input form that is used by all pages, except view pdf and the multitool was not translatable. Since the form default form can not be made translatabel, I implemented a button that goes over it and looks exactly the same, that calls the file input form when clicked. The functionality and style of the button is identical to the original form. For refernece see picture of the new button:
image

Closes #1260

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@t71rs t71rs requested a review from Frooodle as a code owner July 8, 2024 15:11
@github-actions github-actions bot added Front End Issues or pull requests related to front-end development Translation labels Jul 8, 2024
@Frooodle
Copy link
Member

Frooodle commented Aug 3, 2024

@t71rs awesome change! but it seems like the submit button has changed its appearance somewhat, do we need to copy bootstraps exact CSS example for this?

@Ludy87 Ludy87 added the Stale Issues or pull requests that have become inactive label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front End Issues or pull requests related to front-end development needs-changes Stale Issues or pull requests that have become inactive Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button in wrong Language
4 participants