Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on exit #224

Closed
Stivius opened this issue Sep 14, 2019 · 1 comment
Closed

Crash on exit #224

Stivius opened this issue Sep 14, 2019 · 1 comment
Labels

Comments

@Stivius
Copy link
Owner

Stivius commented Sep 14, 2019

Describe the bug
Player crashes on exit sometimes.

To Reproduce

  • Launch the player
  • Close the player window (not ^C in terminal)

Expected behavior
No crash.

Logs
It gives the following message:
Invalid argument (/root/zeromq-4.3.0/src/mutex.hpp:142) Aborted (core dumped)

Environment (please complete the following information):

  • Linux Disto: Manjaro 18.0.4
  • Linux Desktop Environment: XFCE
  • How the player was launched: snap
  • Player Version: 1.8-R2
@Stivius Stivius added the bug label Sep 14, 2019
@Stivius Stivius added this to the 1.8 R5 milestone Sep 20, 2019
Stivius pushed a commit that referenced this issue Nov 6, 2019
Remove cppzmq because it updates much slower comparing to original zeromq. Context is terminated
after all sockets has been closed. #224
@Stivius
Copy link
Owner Author

Stivius commented Nov 6, 2019

This issue was due to an internal error in zeromq 4.3.0. I've found the discussion here: zeromq/libzmq#2991

Apart from that, I've decided to remove cppzmq because these bindings are updated much slower than the original library. Moreover, they use custom versioning that doesn't conform to the original lib versioning.

Also, termination wasn't done correctly before. According to ZMQ docs, zmq::context should be terminated only after all zmq::socket have been closed. Now we have 3-steps termination:

  • shutdown any blocking operation on zmq::socket thread
  • join zmq::socket thread
  • and now we can safely call terminate function to destroy and free context resource

@Stivius Stivius closed this as completed Nov 6, 2019
@Stivius Stivius removed this from the 1.8 R5 milestone Jan 8, 2020
Stivius pushed a commit that referenced this issue Dec 24, 2020
feat: add separate tab to list invalid files in status screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant