Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer builds with futures-rs 0.3.31 #8

Closed
awused opened this issue Oct 11, 2024 · 2 comments
Closed

No longer builds with futures-rs 0.3.31 #8

awused opened this issue Oct 11, 2024 · 2 comments

Comments

@awused
Copy link

awused commented Oct 11, 2024

There was a breaking soundness fix in 0.3.31, seems like it's not a trivial fix. rust-lang/futures-rs#2830


error[E0310]: the parameter type `K` may not live long enough
   --> src/mapped_futures/task.rs:104:9
    |
104 |         waker_ref(this)
    |         ^^^^^^^^^^^^^^^
    |         |
    |         the parameter type `K` must be valid for the static lifetime...
    |         ...so that the type `K` will meet its required lifetime bounds
    |
help: consider adding an explicit lifetime bound
    |
101 | impl<K: Hash + Eq + 'static, Fut> Task<K, Fut> {
    |                   +++++++++

FuturesUnordered had to make a copy of WakerRef without static bounds https://github.com/rust-lang/futures-rs/pull/2830/files#diff-4749c3509fed684159acdaa05f4c30240798a7c201aaa5ecc0e25641b4b6b9d6

@Meisterian
Copy link
Contributor

I have added a PR today that may fix this issue:
#7

@StoicDeveloper
Copy link
Owner

resolved #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants