Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'static bound to waker_ref #2830

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Add 'static bound to waker_ref #2830

merged 1 commit into from
Feb 26, 2024

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Feb 25, 2024

Fixes #2795

@taiki-e taiki-e added the A-task Area: futures::task label Feb 25, 2024
@taiki-e taiki-e merged commit 4f4b032 into master Feb 26, 2024
24 checks passed
@taiki-e taiki-e deleted the waker_ref branch February 26, 2024 14:36
@taiki-e taiki-e added the 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. label Feb 26, 2024
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Oct 5, 2024
@taiki-e taiki-e mentioned this pull request Oct 5, 2024
jonhoo added a commit to jonhoo/streamunordered that referenced this pull request Oct 19, 2024
This is technically a breaking change, but allowed since it fixes a
soundness issue in futures-util (rust-lang/futures-rs#2830).

Fixes #8.
Closes #9.
jonhoo added a commit to jonhoo/streamunordered that referenced this pull request Oct 19, 2024
This is technically a breaking change, but allowed since it fixes a
soundness issue in futures-util (rust-lang/futures-rs#2830).

Fixes #8.
Closes #9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

futures_task::waker_ref() is unsound
2 participants