Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Henry/sto 617 aptos contract implementation #70

Merged
merged 19 commits into from
Jan 14, 2025
Merged

Henry/sto 617 aptos contract implementation #70

merged 19 commits into from
Jan 14, 2025

Conversation

HenryMBaldwin
Copy link
Collaborator

@HenryMBaldwin HenryMBaldwin commented Jan 10, 2025 •
edited
Loading

Aptos Contract, Admin CLI, and CI workflow

@HenryMBaldwin
aptos init.
ebdfcc8
@HenryMBaldwin
First pass at aptos contract. Doesn't compile.
919c559
@HenryMBaldwin
It compiles! Switched to dot notation for functions, reworked update …
aa8fb25 
…functions to use pure values.
@HenryMBaldwin
Passing all tests with 97% total test coverage.
b29da02
@HenryMBaldwin
Clarify that fee is expressed in octas and eliminated all compiler wa…
40374b6 
…rnings.
@HenryMBaldwin
Move test only vector imports into test imports.
02cec5f
@HenryMBaldwin
Change owner to be first param in init.
bd2600c
@HenryMBaldwin
Reworked to keep track of state object in state_object_store.
04c31c8
@HenryMBaldwin
Update function signatures to accept mag and neg and clean up comments.
58f860f
@HenryMBaldwin
Reworked to use account to store state instead of object to allow fee…
c3b97c0 
… storage.
@HenryMBaldwin
Remove address from StorkState object.
45ab686
@HenryMBaldwin
Admin cli for aptos contract.
6030330
@HenryMBaldwin
Merge branch 'aptos-integration' into henry/sto-617-aptos-contract-im…
80e07d4 
…plementation
@HenryMBaldwin
Add aptos test workflow.
c00e1a1
@HenryMBaldwin
remove rust setup from aptos test.
9ea4b94
@HenryMBaldwin
Change python cache.
6ab4912
akawalsky
akawalsky reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@akawalsky akawalsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this looks good. Just one comment but we will be sure to get this fully audited.

Also, what is the upgrade pattern here?

contracts/aptos/contracts/sources/state.move Show resolved Hide resolved
@HenryMBaldwin HenryMBaldwin merged commit 84aee3e into aptos-integration Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akawalsky akawalsky akawalsky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenryMBaldwin @akawalsky