fix: False negatives in some cases when calling JSONSchema.apply on…

… schemas with `if` and `then` (without `else`) keywords Ref: #318
Stranger6667 · Dec 8, 2021 · 1139d29 · 1139d29
1 parent 8740c4c
commit 1139d29
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 ### Fixed
 
 - False positives in some cases when calling `JSONSchema.apply` on a schema with `additionalProperties`, `patternProperties`, and `properties` combined.
+- False negatives in some cases when calling `JSONSchema.apply` on schemas with `if` and `then` (without `else`) keywords. [#318](https://github.com/Stranger6667/jsonschema-rs/pull/318)
 
 ### Performance
 

diff --git a/jsonschema/src/keywords/if_.rs b/jsonschema/src/keywords/if_.rs
@@ -65,8 +65,10 @@ impl Validate for IfThenValidator {
         if if_result.is_valid() {
             let then_result = self.then_schema.apply_rooted(instance, instance_path);
             if_result += then_result;
+            if_result.into()
+        } else {
+            PartialApplication::valid_empty()
         }
-        if_result.into()
     }
 }