Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store & use meta-schemas #28

Closed
Stranger6667 opened this issue Mar 29, 2020 · 2 comments · Fixed by #169
Closed

Store & use meta-schemas #28

Stranger6667 opened this issue Mar 29, 2020 · 2 comments · Fixed by #169

Comments

@Stranger6667
Copy link
Owner

Stranger6667 commented Mar 29, 2020

If we'll validate the input schemas for conformance to the respective specs, then:

  • We probably can skip a lot of our own checks during the compilation process
  • There will be an understandable error message in case if the input schema is not valid

Regarding the implementation details - it can be done via lazy_static! so the schema is not re-compiled. In the perfect scenario I'd like to have it done via code-generation (like described here - #46)

@darwin67
Copy link

It would be helpful to have better schema validation error messages.
We don't need code generation since the schemas are not pre-defined and are stored in a database. But without better error messages for schemas themselves, it's pretty hard for someone who might not be familiar with the specs to figure what they did wrong.

@Stranger6667
Copy link
Owner Author

Sorry @darwin67 I missed your message.
The error messages should be covered by #100 - I hope to work on it in the next few months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants